This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
index_as_columns option in ctable.fromdataframe() #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -644,13 +644,17 @@ def copy(self, **kwargs): | |||
| return ccopy | |||
|
|
|||
| @staticmethod | |||
| def fromdataframe(df, **kwargs): | |||
| def fromdataframe(df, index_as_columns=False, **kwargs): | |||
There was a problem hiding this comment.
Although backward incompatible, I'd say that setting index_as_columns to True as default makes more sense.
There was a problem hiding this comment.
I had the backward compatibility in mind, but I do agree that index_as_columns to True as a default makes more sense.
| # In Python 3 strings should be represented as Unicode | ||
| dtype = "U" if sys.version_info >= (3, 0) else "S" | ||
| col = bcolz.carray(vals, dtype='%s%d' % | ||
| (dtype, maxitemsize), **ckwargs) |
There was a problem hiding this comment.
I think that 'unicode' and 'string' branches can be fused a bit more.
|
Looks good to me; I have added a couple of comments though. Also, a couple of test units would be needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on #344
Makes df -->ct-->df rountrip possible.
index_as_columnsto save the index of a dataframe inctable.fromdataframe()method.ctable.todataframe()method to check fordataframe_index_columnsattribute and if found set the dataframe index to this column before returning it.