Add post on PyTables direct chunking API #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by @FrancescAlted.
FrancescAlted
approved these changes
Aug 23, 2024
posts/pytables-direct-chunking.rst
Outdated
| :width: 75% | ||
| :align: center | ||
|
|
||
| In this case direct chunking yields 4.5x write and 1.9x read speedups, with write/read speeds of 0.8 GB/s and 1.6 GB/s. The absolute numbers are of course not as impressive, but the performance is still much better than that of the regular mechanism, especially when writing. Please note that the M1 CPU has a hybrid efficiency+performance core configuration. We also run the tests on another hybrid CPU of the high-performance range, in this case an Intel Core i9-13900K CPU with 8+16 cores and 32 MB L2 cache, clocked at 5.7 GHz: |
There was a problem hiding this comment.
To be honest, I'd not add so many benchmarks of different machines, as this can overwhelm readers a bit ;-). I'd skip the Intel machine, as it has a similar architecture (and behavior) than the AMD.
There was a problem hiding this comment.
Yup, I agree, though the write results on the Intel are IMO too good not to mention them, so I replaced the whole passage with a short summary sentence in commit fa0dc00. Does it look ok to you like this?
To avoid overwhelming the reader, as suggested by @FrancescAlted.
|
Thanks @FrancescAlted and @avalentino for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The development of this feature was funded by the NumFOCUS Foundation under a Small Development Grant.