Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute threshold in memodel example if not threshold-based protocols #154

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

No description provided.

Change-Id: I5209944dcdec1fd746e195840ba453e79da05187
@AurelienJaquier AurelienJaquier self-assigned this Jul 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (737fa7d) to head (7c4ece3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   53.44%   53.45%           
=======================================
  Files         122      122           
  Lines        9667     9668    +1     
=======================================
+ Hits         5167     5168    +1     
  Misses       4500     4500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change-Id: I48b0a03f8ef5f2466bbcd9b37b3effafca9c819e
@AurelienJaquier
Copy link
Collaborator Author

I have increased the precision of threshold search, because for some cells with low threshold, the search was not very good (e.g. finding threshold at 0.023 when 'real' threshold is at 0.016). However, this will make the optimisations non-reproducible with the next BPEM version. Is that ok @darshanmandge ?

@darshanmandge
Copy link
Collaborator

Is it possible to have precision set only for me-models for now and not for emodels? All the emodels built won't generate the same result if we do this which might be a problem for reproducibility of downstream results e.g. if they have been used in a circuit .

Change-Id: I37bc2ba549d707b8a719e3c90c6eccf73bed761b
@AurelienJaquier AurelienJaquier merged commit e2b25a3 into main Jul 9, 2024
6 checks passed
@AurelienJaquier AurelienJaquier deleted the memodel-threshold branch July 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants