Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix morph_modifiers check #157

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix morph_modifiers check #157

merged 1 commit into from
Jul 9, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jul 9, 2024

When morph_modifiers was an empty list, the check incorrectly evaluated it as false, leading to the use of default morph_modifiers

@ilkilic ilkilic self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (8d5b0ab) to head (5ff951b).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   60.07%   53.45%   -6.63%     
==========================================
  Files         109      122      +13     
  Lines        7838     9668    +1830     
==========================================
+ Hits         4709     5168     +459     
- Misses       3129     4500    +1371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @AurelienJaquier we have check emodels now with this change

@ilkilic ilkilic merged commit 42d7b26 into main Jul 9, 2024
6 checks passed
@ilkilic ilkilic deleted the fix-morph-modifiers branch July 9, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants