Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix thumbanil for absolute amplitude protocols #174

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

AurelienJaquier
Copy link
Collaborator

We had to take into account that the amplitude might have a point in it, e.g. 0.2.

Jaquier Aurélien Tristan added 2 commits October 3, 2024 10:32
Change-Id: I86885c011854ca3f16c7f796c93e87d1cad3f846
Change-Id: I207efee537a7bc265f784eaa73ef9dc4bdc08a0e
@AurelienJaquier AurelienJaquier self-assigned this Oct 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.46%. Comparing base (8d5b0ab) to head (b3ccd78).
Report is 113 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   60.07%   52.46%   -7.62%     
==========================================
  Files         109      124      +15     
  Lines        7838    10433    +2595     
==========================================
+ Hits         4709     5474     +765     
- Misses       3129     4959    +1830     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AurelienJaquier AurelienJaquier merged commit 3be0b7d into main Oct 3, 2024
6 checks passed
@AurelienJaquier AurelienJaquier deleted the fix-thumbnail branch October 3, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants