Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PG dependency to latest version to fix security vulerability #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattisfrommars
Copy link

The PG module used has a "critical" security flaw in and shouldn't be depended on any more

@RWOverdijk
Copy link
Collaborator

3 breaking changes equals the need for some serious testing.

@mattisfrommars
Copy link
Author

Agreed. Can you help me to get the automated test suite running? I'm getting the following error:

  cli 0.10-rc8
Possibly unhandled Error: Cannot find module 'path/to/sails-migrations/test/fixtures/sample_apps/0.10-rc8/node_modules/sails/package'```

I can't find any documentation on how to get the tests running either. (Once I understand what the issue is I'm happy to help improve the docs)

@RWOverdijk
Copy link
Collaborator

I think this repo is just outdated and requires a lot of work to function with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants