Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker #11

Merged
merged 3 commits into from
Nov 8, 2023
Merged

added docker #11

merged 3 commits into from
Nov 8, 2023

Conversation

BlueVioletTeti
Copy link
Owner

No description provided.

Copy link

@Denis-Balako Denis-Balako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Left few optional suggestions.

Dockerfile Outdated
Comment on lines 1 to 8
#Builder stage
FROM openjdk:17-jdk-alpine as builder
WORKDIR application
ARG JAR_FILE=target/*.jar
COPY ${JAR_FILE} application.jar
RUN java -Djarmode=layertools -jar application.jar extract

#Final stage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments

Comment on lines 1 to 4
#spring.datasource.url=jdbc:mysql://localhost:3306/books_app?serverTimezone=UTC
#spring.datasource.username=root
#spring.datasource.password=imdv306
#spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments

Copy link

@andrii-hoienko andrii-hoienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary comments

spring.datasource.username=root
spring.datasource.password=imdv306
spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
#spring.datasource.url=jdbc:mysql://localhost:3306/books_app?serverTimezone=UTC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove unnecessary comments?

Copy link

@andrii-hoienko andrii-hoienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@BlueVioletTeti BlueVioletTeti merged commit 90127e7 into master Nov 8, 2023
2 checks passed
@BlueVioletTeti BlueVioletTeti deleted the dev-docker branch November 8, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants