added data validation and global exception handler #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegTuryk
reviewed
Sep 11, 2023
| private String author; | ||
| @NotNull | ||
| private String isbn; |
OlegTuryk
approved these changes
Sep 11, 2023
vovasalyha
suggested changes
Sep 11, 2023
pom.xml
Outdated
| @@ -71,6 +71,12 @@ | |||
| <artifactId>liquibase-maven-plugin</artifactId> | |||
| <version>4.23.1</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.hibernate.validator</groupId> | |||
There was a problem hiding this comment.
In Spring Boot it's better to choose starters over concrete dependencies, so I suggest to use validation starter
| import java.math.BigDecimal; | ||
| import lombok.Data; | ||
|
|
||
| @Data | ||
| public class CreateBookRequestDto { | ||
| @NotNull | ||
| private String title; |
There was a problem hiding this comment.
Validate the size of title to not allow empty titles and to not exceed the maximum size set by DB schema, the same for author field
| private String author; | ||
| @NotNull | ||
| private String isbn; |
There was a problem hiding this comment.
isbn has other validation rule except of not null (see Oleg's suggestion)
| ) { | ||
| Map<String, Object> body = new LinkedHashMap<>(); | ||
| body.put("timestamp", LocalDateTime.now()); | ||
| body.put("status", HttpStatus.BAD_REQUEST); |
There was a problem hiding this comment.
Usually invalid arguments it's 422 response code. Also, define the common response format for the application and create a class with exception response body.
…ded http response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.