Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nominal concrete cover check #350

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Implement nominal concrete cover check #350

wants to merge 10 commits into from

Conversation

SZeltaat
Copy link
Contributor

@SZeltaat SZeltaat commented Sep 4, 2024 •
edited
Loading

Description

  • Eurocode allows for marginal reduction of cover (Δc_dev to be precise). That is not implemented. I've never seen it being used and the conditions are too specific.

Progress

  • Check class/function for nominal concrete cover
  • implementation of design allowance for deviation
  • LateX report
  • tests
  • example for documentation

Fixes #343

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@SZeltaat SZeltaat linked an issue Sep 4, 2024 that may be closed by this pull request
[✨ Feature request]: Nominal concrete cover check #343
Open
7 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Thank you so much for contributing to Blueprints! This is your Pull Request # 7 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@egarciamendez
Copy link
Member

@SZeltaat I've had a couple of very busy weeks but I'm planning to get to this one sometime next week. Would love to implement this check into the next release.

@SZeltaat
Copy link
Contributor Author

SZeltaat commented Oct 9, 2024

@egarciamendez, sounds good! I on the other hand had a couple of boring weeks doing nothing 😉. I have some time for BP next week (on top of our wednesday work session of course). I'll pick up some tasks then.

@SZeltaat
Copy link
Contributor Author

SZeltaat commented Oct 9, 2024

@egarciamendez, I was thinking.... I have defined all the year- and country-specific Eurocode constants in a seperate file and imported those in the file where the cover calculation is implemented. This is "very hardcoded".
I suggest turning all the constants into one dataclass and passing that into the NominalConcreteCover. This makes it very flexible.
Let me know how you feel about this suggestion.

@egarciamendez
Copy link
Member

@egarciamendez, I was thinking.... I have defined all the year- and country-specific Eurocode constants in a seperate file and imported those in the file where the cover calculation is implemented. This is "very hardcoded". I suggest turning all the constants into one dataclass and passing that into the NominalConcreteCover. This makes it very flexible. Let me know how you feel about this suggestion.

Sounds like a good idea. Go for it

egarciamendez
egarciamendez requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface is not user-friendly right now. Let's change that.

blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/nominal_concrete_cover.py Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/nominal_concrete_cover.py Outdated Show resolved Hide resolved
blueprints/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_4_durability_and_cover/formula_4_1.py Show resolved Hide resolved
SZeltaat
SZeltaat commented Oct 17, 2024
View reviewed changes
Copy link
Contributor Author

@SZeltaat SZeltaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! I've made the changes.

blueprints/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_4_durability_and_cover/formula_4_1.py Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/nominal_concrete_cover.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/nominal_concrete_cover.py Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/base.py Outdated Show resolved Hide resolved
blueprints/checks/nominal_concrete_cover/constants/constants_nen_en_1992_1_1_c2_2011.py Outdated Show resolved Hide resolved
@SZeltaat SZeltaat marked this pull request as ready for review October 17, 2024 12:21
@SZeltaat
Copy link
Contributor Author

@egarciamendez , The only missing part is an example for the documentation. Could you be able to implement that? Let me know!

@egarciamendez
Copy link
Member

@egarciamendez , The only missing part is an example for the documentation. Could you be able to implement that? Let me know!

Off course! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egarciamendez egarciamendez egarciamendez requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@egarciamendez egarciamendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Nominal concrete cover check
2 participants
@SZeltaat @egarciamendez