Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nominal concrete cover check #350

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SZeltaat
Copy link
Contributor

@SZeltaat SZeltaat commented Sep 4, 2024

Description

  • Check class implemented as a subclass to Formula. Is that acceptable? Or do we want to avoid this?
  • The check depends strongly on the release year and the national annex of the Eurocode. Current implementation is semi-flexibel (all specific values are stored in a separate file, but are referenced directly in the check, so no choice for other EC version implemented ). We might want to come up with a protocol for that!
  • Eurocode allows for marginal reduction of cover (Δc_dev to be precise). That is not implemented. I've never seen it being used and the conditions are too specific.

Progress

  • Check class/function for nominal concrete cover
  • implementation of design allowance for deviation
  • LateX report
  • tests
  • example for documentation

Fixes #343

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@SZeltaat SZeltaat linked an issue Sep 4, 2024 that may be closed by this pull request
7 tasks
Copy link

github-actions bot commented Sep 4, 2024

Thank you so much for contributing to Blueprints! This is your Pull Request # 7 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: Nominal concrete cover check
2 participants