-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Exposure classes and adjust tests #306
Conversation
Thank you so much for contributing to Blueprints! This is your Pull Request # 2 to this project. Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_4_durability_and_cover/test_table_4_1.py
Show resolved
Hide resolved
…ub.com/Blueprints-org/blueprints into 305-feature-request-abc-exposure-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review!
I tried changing 'object' to 'T', but mypy complains that the signature is different from its superclass. I have tried a couple of other possible solutions, but with no luck. So I'm keeping 'object' in. If you can think of a solution, please let me know or feel free to apply it yourself!
I'll wait for your response before merging! 😉
tests/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_4_durability_and_cover/test_table_4_1.py
Show resolved
Hide resolved
Sometimes is a 9 just fine 👌 |
Description
Refactored and replaced exposure classes. Main change is the definition of ABCEnumMeta class to be able to make Exposure an abstract class. This was required if we want to define the concept of exposure class independant of the exact definition in different Eurocode versions.
I had to do this in order to be able to do the same for the structural class and the cover calculation.
All the other changes are mostly replacing code.
Please also read #305
Fixes #305
Type of change
Please delete options that are not relevant.
Checklist: