Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exposure classes and adjust tests #306

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

SZeltaat
Copy link
Contributor

@SZeltaat SZeltaat commented Jul 8, 2024

Description

Refactored and replaced exposure classes. Main change is the definition of ABCEnumMeta class to be able to make Exposure an abstract class. This was required if we want to define the concept of exposure class independant of the exact definition in different Eurocode versions.
I had to do this in order to be able to do the same for the structural class and the cover calculation.
All the other changes are mostly replacing code.

Please also read #305
Fixes #305

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@SZeltaat SZeltaat linked an issue Jul 8, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Jul 8, 2024

Thank you so much for contributing to Blueprints! This is your Pull Request # 2 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@SZeltaat SZeltaat self-assigned this Jul 9, 2024
@SZeltaat SZeltaat marked this pull request as ready for review July 9, 2024 10:58
Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful !
afbeelding

Copy link
Contributor Author

@SZeltaat SZeltaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review!
I tried changing 'object' to 'T', but mypy complains that the signature is different from its superclass. I have tried a couple of other possible solutions, but with no luck. So I'm keeping 'object' in. If you can think of a solution, please let me know or feel free to apply it yourself!
I'll wait for your response before merging! 😉

@egarciamendez
Copy link
Member

Sometimes is a 9 just fine 👌

@SZeltaat SZeltaat merged commit 67b008d into main Jul 11, 2024
4 checks passed
@SZeltaat SZeltaat deleted the 305-feature-request-abc-exposure-class branch July 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: ABC Exposure class
2 participants