Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line class added #309

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Line class added #309

merged 7 commits into from
Jul 17, 2024

Conversation

egarciamendez
Copy link
Member

@egarciamendez egarciamendez commented Jul 16, 2024

Description

An objecte representation of a line.

Fixes #268

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@egarciamendez egarciamendez self-assigned this Jul 16, 2024
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 3 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copy link
Contributor

@bro-wi bro-wi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement on the previous version! Only some minor remarks.

blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
blueprints/geometry/line.py Outdated Show resolved Hide resolved
@egarciamendez
Copy link
Member Author

@bro-wi Thanks for your review :-) I have made the changes accordingly

@egarciamendez egarciamendez merged commit 7182fb1 into main Jul 17, 2024
4 checks passed
@egarciamendez egarciamendez deleted the 268_calculations branch July 17, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨ Feature request]: EPIC: Rectangular Reinforced Cross Section
2 participants