Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Formula 5.16 from NEN-EN 1992-1-1+C2:2011: Chapter 5 - Structural Analysis #328

Conversation

RamiEvans
Copy link
Contributor

Included changes to type aliases to support compound units such as kNm2 Included tests (slight deviation from standard by using pytest fixture for setup and tear down)

Description

Added formula 5.17 for effective length of buckling load
Added new compound units - this allows us to make use of compounds such as EI

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] New feature (non-breaking change which adds functionality)

Checklist:

  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] New and existing unit tests pass locally with my changes

Included changes to type aliases to support compound units such as kNm2
Included tests (slight deviation from standard by using pytest fixture for setup and tear down)
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 1 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamiEvans Great having you onboard!
Just some minor changes needed on this PR.

Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@egarciamendez egarciamendez merged commit 39d50d6 into main Sep 4, 2024
4 checks passed
@egarciamendez egarciamendez deleted the 169-feature-request-add-formula-517-from-NEN_EN_1992_1_1_C2_2011 branch September 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants