Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#89) added formula 8.17 from NEN-EN 1992-1-1+C2:2011 #90

Merged
merged 7 commits into from
Dec 27, 2023
Merged

(#89) added formula 8.17 from NEN-EN 1992-1-1+C2:2011 #90

merged 7 commits into from
Dec 27, 2023

Conversation

PetervWestrienen
Copy link
Collaborator

@PetervWestrienen PetervWestrienen commented Dec 22, 2023 •
edited by egarciamendez
Loading

Description

Added formula 8.17 from NEN-EN 1992-1-1+C2:2011

Fixes #83

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
    image

@PetervWestrienen PetervWestrienen self-assigned this Dec 22, 2023
@PetervWestrienen PetervWestrienen linked an issue Dec 22, 2023 that may be closed by this pull request
[✨ Feature request]: Add formula 8.17 from NEN-EN 1992-1-1+C2:2011 #89
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Thank you so much for contributing to Blueprints! This is your Pull Request # 22 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

@PetervWestrienen PetervWestrienen changed the title (#83) added formula 8.17 from NEN-EN 1992-1-1+C2:2011 (#89) added formula 8.17 from NEN-EN 1992-1-1+C2:2011 Dec 22, 2023
egarciamendez
egarciamendez requested changes Dec 26, 2023
View reviewed changes
Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just a really minor typo yet to fix.

...92_1_1_c2_2011/chapter_8_detailing_of_reinforcement_and_prestressing_tendons/formula_8_17.py Outdated

class Form8Dot17DesignValueTransmissionLength1(Formula):
"""Class representing formula 8.17 for the calculation of design value 1 of the transmission length :math:`l_{pt1}`. The less favourable of
:math:`l_{pt1}` or :math:`l_{pt2} has to be chosen depending on the design situation`"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ' after l_{pt2}

egarciamendez
egarciamendez approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@egarciamendez egarciamendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@egarciamendez egarciamendez merged commit 98550bf into main Dec 27, 2023
4 checks passed
@egarciamendez egarciamendez deleted the 89-feature-request-add-formula-817-from-nen-en-1992-1-1+c22011 branch December 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egarciamendez egarciamendez egarciamendez approved these changes

Assignees

@PetervWestrienen PetervWestrienen

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PetervWestrienen @egarciamendez