Skip to content

Commit

Permalink
setup: require at least Python 3.7
Browse files Browse the repository at this point in the history
Python 3.6 is end-of-life since 2021-12-23. Even though 3.7 is also not
supported any more, Debian oldoldstable is still using it. We don't gain
much by dropping its support so let's keep it for the time being.
  • Loading branch information
jkloetzke committed Aug 10, 2024
1 parent d6b23d8 commit 53f9ce2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
fail-fast: false

steps:
Expand Down Expand Up @@ -46,8 +46,6 @@ jobs:
python3 setup.py bdist_wheel --plat-name manylinux1_x86_64
- name: Upload coverage to Codecov
# Coverage is not complete on Python <3.7 (see pym/bob/utils.py)
if: matrix.python-version != '3.6'
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion doc/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Installation
Dependencies
============

Bob is built with Python3 (>=3.6). Some additional Python packages are
Bob is built with Python3 (>=3.7). Some additional Python packages are
required. They are installed automatically as dependencies.

Apart from the Python dependencies additional run time dependencies could arise,
Expand Down
4 changes: 2 additions & 2 deletions pym/bob/develop/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
if sys.version_info.major != 3:
print("Bob requires Python 3")
sys.exit(1)
elif sys.version_info.minor < 6:
print("Bob requires at least Python 3.6")
elif sys.version_info.minor < 7:
print("Bob requires at least Python 3.7")
sys.exit(1)

def getVersion():
Expand Down
5 changes: 2 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class build(build_orig):
cmdclass = cmdclass,

# Our runtime dependencies
python_requires = '>=3.6',
python_requires = '>=3.7',
install_requires = [
'PyYAML',
'schema',
Expand All @@ -144,8 +144,7 @@ class build(build_orig):

# Installation time dependencies only needed by setup.py
setup_requires = [
'setuptools_scm<7', # automatically get package version
# TODO: remove constraint when Python 3.7 is required
'setuptools_scm', # automatically get package version
],

# Provide executables
Expand Down

0 comments on commit 53f9ce2

Please sign in to comment.