Fix coverage for URL SCM #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archive unit tests used the implicit ThreadPoolExecutor while the URL SCM unit tests used the ProcessPoolExecutor like the rest of Bob. This had the effect that the URL SCM unit tests did not provide full coverage.
Black box and unit tests use the same configuration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 88.33% 88.72% +0.38%
==========================================
Files 46 46
Lines 14696 14697 +1
==========================================
+ Hits 12982 13040 +58
+ Misses 1714 1657 -57 ☔ View full report in Codecov by Sentry. |
If the file exists and shall not be overwritten, the handle must be closed.
Also log events that are not visible by the default BaseHTTPRequestHandler methods.
If mirrors are configured, a download attempt may fail gracefully if there is another mirror available. The user should still be able to infer what caused the initial request to fail before Bob moved to the next mirror. Thus output the error message of the previous attempt as warning.
The process pool executor is started in some unit tests without being used. This can create the no-data-collected warning that just clutters the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.