Imrove source prediction robustness #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These caching data structures are prone to incorrect data e.g., if some checkout is not really deterministic. The old behaviour was to never replace the files which sets the very first execution result into stone. If that was incorrect, there are no tools to purge the wrong cache except deleting the whole binary archive. Instead, Bob now always uploads the live-build-id and fingerprint caches. These files are small so there should be no performance impact. But at least the cache will reflect the last build, giving the user the possibility to replace the wrong predictions with the right ones.
The Jenkins build is usually used to provide binary artifacts. This implies that the build should be as stable as possible. If a checkout step of some recipe is not fully deterministic, though, then relying on live-build-ids may never rectify the problem. It might also hide such a problem only until the checkout is really forced for some other reason. To increase the robustness, add a "scm.always-checkout" extended option that defaults to "true". If enabled, checkout steps will always be executed and live-build-ids will only be uploaded but never used. If the user wants to rely on live-build-ids to speed up builds he can disable the scm.always-checkout option.
The Jenkins build is usually used for creating binary artifacts and release builds. This is done best by doing clean builds. If the user wants to focus on speed, the --incremental option can be used when creating a new Jenkins alias.
jkloetzke
force-pushed
the
robust-predictions
branch
from
c4a4287
to
b987c12
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 88.91% 88.92%
=======================================
Files 46 46
Lines 14774 14795 +21
=======================================
+ Hits 13137 13156 +19
- Misses 1637 1639 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.