Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add bundle build #585

Closed
wants to merge 1 commit into from
Closed

Conversation

rhubert
Copy link
Contributor

@rhubert rhubert commented Sep 17, 2024

A bob-bundle collects all scm's neccessary to build a package in a tar-file. Next to the tar-file a bundle-config file is generated to be able to rebuild the package only with the bundle.

Such a bundle can be used to build on a air-gapped system or to archive all sources of a build.

A bob-bundle collects all scm's neccessary to build a package in a
tar-file. Next to the tar-file a scmOverrides file is generated to be
able to rebuild the package only with the bundle.

Such a bundle can be used to build on a air-gapped system or to archive
all sources of a build.

ATM only bundling of git and url-scm's is supported.
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 28.47682% with 108 lines in your changes missing coverage. Please review.

Project coverage is 88.04%. Comparing base (080fc60) to head (5cad406).

Files with missing lines Patch % Lines
pym/bob/builder.py 23.07% 60 Missing ⚠️
pym/bob/invoker.py 12.00% 22 Missing ⚠️
pym/bob/scm/git.py 26.92% 19 Missing ⚠️
pym/bob/scm/url.py 57.14% 3 Missing ⚠️
pym/bob/cmds/build/build.py 83.33% 1 Missing ⚠️
pym/bob/scm/cvs.py 66.66% 1 Missing ⚠️
pym/bob/scm/imp.py 66.66% 1 Missing ⚠️
pym/bob/scm/svn.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   88.66%   88.04%   -0.62%     
==========================================
  Files          46       46              
  Lines       14860    15003     +143     
==========================================
+ Hits        13176    13210      +34     
- Misses       1684     1793     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhubert rhubert closed this Sep 18, 2024
@jkloetzke
Copy link
Member

Why closed? I did not look into the details but it at the first glance it sounded like a desirable feature...

@rhubert
Copy link
Contributor Author

rhubert commented Sep 20, 2024

Just to not waste your time. :)

I was caught up by reality shortly after pushing this. The initial idea to bundle only the checkoutScms while still running the checkoutScripts doesn't work for all checkoutScript doing more fetches. (cargo, alire, pip, meson subprojects download ... ). OTOH there are checkoutScripts that might be still needed on the unbundled machine (autoreconf, ...) so this is (as usual) much more complex...

I'm working on an update and will reopen this once I think it might hold a little longer...

@jkloetzke
Copy link
Member

Thanks. :)

I think the only reasonable option is to pack the whole source workspace after the checkout step is finished. Very much like the binary artifacts are treated now for package steps. Of course, this will only work for deterministic checkout steps...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants