resolved issue #22. Yes/No will not be converted to booleans #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DSchreyer
commented
Dec 11, 2024
DSchreyer
commented
|
Would be cool to add a unit test for that |
|
@grst I updated and included a testthat script. Feedback is highly appreciated |
grst
requested changes
Jan 13, 2025
R/read_params.R
Outdated
| @@ -73,7 +72,7 @@ read_params <- function(stage_path = NULL, return_list = FALSE) { | |||
| } | |||
| ) | |||
|
|
|||
| yaml <- read_yaml(tmp_config_file) | |||
| yaml <- read_clean_yaml(tmp_config_file) | |||
There was a problem hiding this comment.
should this be read_safe_yaml?
R/read_params.R
Outdated
| #' @return a list | ||
| #' @importFrom yaml read_yaml | ||
| #' @importFrom purrr modify_tree | ||
| #' @export |
There was a problem hiding this comment.
Suggested change
| #' @export |
I don't think we need to export that. Should also make this warning go away
Warning: Undocumented code objects:
‘read_safe_yaml’
tests/testthat/test-read_params.R
Outdated
Comment on lines
43
to
46
| expect_true(safe_yaml$false_true == safe_yaml$false_true) | ||
| expect_true(safe_yaml$false_false == safe_yaml$false_false) | ||
| expect_true(safe_yaml$false_true2 == safe_yaml$false_true2) | ||
| expect_true(safe_yaml$false_false2 == safe_yaml$false_false2) |
There was a problem hiding this comment.
this would always evaluate to true, would't it? Should the second part be data$?
There was a problem hiding this comment.
oh damn, yeah my bad
|
found a couple of issues, but should be straightforward to resolve |
grst
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.