Split mod_edish input datasets into subject-level and visit-dependent…

…. Finish API spec and early error feedback.
Boehringer-Ingelheim · Jan 22, 2025 · 833f620 · 833f620
1 parent 709c850
commit 833f620
Show file tree

Hide file tree

Showing 8 changed files with 1,285 additions and 83 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: dv.edish
 Type: Package
 Title: eDISH Plot Module for DILI assessment
-Version: 1.0.4
+Version: 1.0.4.9000
 Authors@R: 
     c(
       person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
@@ -30,7 +30,7 @@ Imports:
   shiny (>= 1.8.0),
   stats (>= 4.2.2),
   tidyr (>= 1.3.0),
-  dv.manager (>= 2.0.0-17),
+  dv.manager (>= 2.1.4),
   rmarkdown (>= 2.25)
 Depends: R (>= 4.0)
 Remotes: boehringer-ingelheim/dv.manager@main

diff --git a/R/CM.R b/R/CM.R
@@ -408,7 +408,7 @@ CM <- local({ # _C_hecked _M_odule
     return(res)
   }
 
-  # TODO: Extend to all checker functions
+  # TODO: use check_flags instead and remove
   optional_and_empty <- function(flags, value) {
     return(isTRUE(flags[["optional"]]) && length(value) == 0)
   }
@@ -510,9 +510,6 @@ CM <- local({ # _C_hecked _M_odule
   }
 
   check_choice_from_col_contents <- function(name, value, flags, dataset_name, dataset_value, column, warn, err) {
-    if (optional_and_empty(flags, value)) {
-      return(TRUE)
-    }
     ok <- check_flags(name, value, flags, warn, err) &&
       assert(
         err, all(value %in% dataset_value[[column]]),