Rc/2.1.0 to main #8
Conversation
R/dvloader.R
Outdated
| } else if (toupper(extension) == "SAS7BDAT") { | ||
| data <- haven::read_sas(path) | ||
| } else { | ||
| stop("Internal error. Report this message to the maintainer of the `dv.loader` package.") |
There was a problem hiding this comment.
I would write somehting like this:
| stop("Internal error. Report this message to the maintainer of the `dv.loader` package.") | |
| stop("Not supported file type, only .rds or .sas7bdat files can be loaded.") |
There was a problem hiding this comment.
As suggested, the error message has been revised. a179d2b
README.md
Outdated
| '.RDS' files. The function will prefer '.RDS' files over '.sas7bdat' files by default. | ||
| The `dv.loader` package provides functionality for loading `.rds` and `.sas7bdat` data files into R. It offers two main functions: | ||
|
|
||
| - `load_data()`: A legacy function that loads data files from a specified subdirectory of the base path defined by the environment variable "RXD_DATA". |
There was a problem hiding this comment.
I wouldn't call it legacy function, I think our users will still want to use this function because they don't need to set the full path.
README.md
Outdated
| - `load_data()`: A legacy function that loads data files from a specified subdirectory of the base path defined by the environment variable "RXD_DATA". | ||
| - `load_files()`: A newer function that provides more flexibility by accepting file paths directly and supports custom names for the returned data list. | ||
|
|
||
| NOTE: The `load_files()` function is recommended for its enhanced capabilities and flexibility. |
There was a problem hiding this comment.
Do we really recomend the load_files function?
I think it's more for people who want to have more flexibility, but the average user probably wants to use the load_data function.
There was a problem hiding this comment.
The documentation now describes load_data() and load_files() as the two main functions for loading data, each designed for different use cases.
R/dvloader.R
Outdated
| checkmate::assert_character(file_paths, min.len = 1) | ||
| checkmate::assert_file_exists(file_paths, access = "r", extension = c("rds", "sas7bdat")) | ||
|
|
||
| read_file_and_attach_metadata <- function(path) { |
There was a problem hiding this comment.
Should we put this function into utils.R?
There was a problem hiding this comment.
This function has been moved to utils.R, allowing it to be used by both load_data() and load_files().
Added
load_files()to load data using explicit file paths. The code of the legacyload_data()function remains unchanged.