Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Test Coverage Threshold and Badge #72

Merged
merged 26 commits into from
Oct 25, 2023
Merged

Add Unit Test Coverage Threshold and Badge #72

merged 26 commits into from
Oct 25, 2023

Conversation

kehoecj
Copy link
Collaborator

@kehoecj kehoecj commented Oct 18, 2023

This PR adds the following functionality:

  • Checks the overall coverage against a threshold. Currently set 95% but I'll create a follow-up story
  • Generates a coverage badge from the pipeline for both index.md and README.md

We have so many awesome OSS Community Contribution Contributions from the OSS Community PR's it'd be nice to be able to see in the PR that unit test coverage has remained within the threshold

Badge can be seen in my fork: https://github.com/kehoecj/config-file-validator/tree/main#readme

Closes #23

@kehoecj kehoecj requested review from jackswiney and jd4235 October 18, 2023 21:43
@kehoecj kehoecj added the CI/CD CI/CD work including Github Actions label Oct 18, 2023
.github/workflows/go.yml Outdated Show resolved Hide resolved
@jd4235
Copy link
Contributor

jd4235 commented Oct 25, 2023

Nice! LGTM.

@kehoecj kehoecj merged commit 92a2ee1 into Boeing:main Oct 25, 2023
4 checks passed
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
* adding badge workflow

* updating execution rules

* fixing yaml error

* fixing yaml

* running script

* switching to inline script

* updating coverage threshold

* chore: Updated coverage badge.

* updating coverage threshold

* chore: Updated coverage badge.

* updating badge job

* chore: Updated coverage badge.

* updating badge job

* chore: Updated coverage badge.

* updates before PR review

* fix name

* fixing status logic

* changing index file

* fixing setting the var

* chore: Updated coverage badge.

* adding index to git add cmd

* chore: Updated coverage badge.

* adding back verbose unit test output

* chore: Updated coverage badge.

* push the badge changes to the branch

---------

Co-authored-by: GitHub Action <[email protected]>
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
* adding badge workflow

* updating execution rules

* fixing yaml error

* fixing yaml

* running script

* switching to inline script

* updating coverage threshold

* chore: Updated coverage badge.

* updating coverage threshold

* chore: Updated coverage badge.

* updating badge job

* chore: Updated coverage badge.

* updating badge job

* chore: Updated coverage badge.

* updates before PR review

* fix name

* fixing status logic

* changing index file

* fixing setting the var

* chore: Updated coverage badge.

* adding index to git add cmd

* chore: Updated coverage badge.

* adding back verbose unit test output

* chore: Updated coverage badge.

* push the badge changes to the branch

---------

Co-authored-by: GitHub Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD work including Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate local unit test coverage badge and set coverage threshold
4 participants