-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Test Coverage Threshold and Badge #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd4235
reviewed
Oct 19, 2023
jackswiney
approved these changes
Oct 19, 2023
Nice! LGTM. |
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* adding badge workflow * updating execution rules * fixing yaml error * fixing yaml * running script * switching to inline script * updating coverage threshold * chore: Updated coverage badge. * updating coverage threshold * chore: Updated coverage badge. * updating badge job * chore: Updated coverage badge. * updating badge job * chore: Updated coverage badge. * updates before PR review * fix name * fixing status logic * changing index file * fixing setting the var * chore: Updated coverage badge. * adding index to git add cmd * chore: Updated coverage badge. * adding back verbose unit test output * chore: Updated coverage badge. * push the badge changes to the branch --------- Co-authored-by: GitHub Action <[email protected]>
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* adding badge workflow * updating execution rules * fixing yaml error * fixing yaml * running script * switching to inline script * updating coverage threshold * chore: Updated coverage badge. * updating coverage threshold * chore: Updated coverage badge. * updating badge job * chore: Updated coverage badge. * updating badge job * chore: Updated coverage badge. * updates before PR review * fix name * fixing status logic * changing index file * fixing setting the var * chore: Updated coverage badge. * adding index to git add cmd * chore: Updated coverage badge. * adding back verbose unit test output * chore: Updated coverage badge. * push the badge changes to the branch --------- Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality:
index.md
andREADME.md
We have so many awesome OSS Community ContributionContributions from the OSS Community
PR's it'd be nice to be able to see in the PR that unit test coverage has remained within the threshold
Badge can be seen in my fork: https://github.com/kehoecj/config-file-validator/tree/main#readme
Closes #23