remedy logic, gemfile, gemspec, CI #1

Robgra13 · 2024-10-09T16:55:35Z

No description provided.

Robgra13 · 2024-10-09T17:05:19Z

Rspec fail is not surprise as spec is designed to fail (I am checking if everything works)

Azdaroth · 2024-10-10T06:14:52Z

Gemfile

+gem "rubocop-performance"
+gem "rubocop-rake"
+gem "rubocop-rspec"
+gem 'sidekiq'


Sidekiq should ideally be a an actual dependency in the gemspec, Gemfile is fo development dependencies

Azdaroth · 2024-10-10T06:16:22Z

Gemfile.lock

@@ -0,0 +1,88 @@
+PATH


Gemfile.lock for gems should be in .gitignore, odd that it was not there from the beginning

@Robgra13 looks like you haven't deleted it

Azdaroth · 2024-10-10T06:16:49Z

README.md

-TODO: Delete this and the text below, and describe your gem
-
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/sidekiq/poison/pill/remedy`. To experiment with that code, run `bin/console` for an interactive prompt.
+The Sidekiq Poison Pill Remedy gem enhances Sidekiq's job processing by automatically handling and rescheduling failed jobs (poison pills) with integrated logging and error tracking through Sentry, ultimately improving reliability and performance optimization.


AI or own copywriting? ;P

I wanted this to be pro so AI 🤖

Azdaroth · 2024-10-10T06:17:21Z

lib/sidekiq_poison_pill_remedy.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require_relative "../lib/remedy/version"


do we need it here?

Azdaroth · 2024-10-10T06:17:48Z

sidekiq-poison-pill-remedy.gemspec

  spec.license = "MIT"
  spec.required_ruby_version = ">= 3.0.0"

-  spec.metadata["allowed_push_host"] = "TODO: Set to your gem server 'https://example.com'"
+  # spec.metadata["allowed_push_host"] = "TODO: Set to your gem server 'https://example.com'"


to be removed

Azdaroth · 2024-10-10T06:18:04Z

sidekiq-poison-pill-remedy.gemspec

-  spec.homepage = "TODO: Put your gem's website or public repo URL here."
+  spec.summary = "Enhances Sidekiq's job processing by automatically handling and rescheduling failed jobs (poison pills)"
+  spec.description = "Enhances Sidekiq's job processing by automatically handling and rescheduling failed jobs (poison pills)"
+  spec.homepage = "https://example.com"


put github repo URL here

Azdaroth · 2024-10-10T06:18:09Z

sidekiq-poison-pill-remedy.gemspec


  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
-  spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
+  spec.metadata["source_code_uri"] = "https://example.com"


put github repo URL here

Azdaroth · 2024-10-10T06:18:29Z

sidekiq-poison-pill-remedy.gemspec

-  spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
-  spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."
+  spec.metadata["source_code_uri"] = "https://example.com"
+  spec.metadata["changelog_uri"] = "https://example.com"


put github repo URL here, leading to Changelog, should be created by default

Azdaroth · 2024-10-10T06:19:11Z

spec/spec_helper.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true

-require "sidekiq/poison/pill/remedy"
+require_relative '../lib/sidekiq_poison_pill_remedy'


it should be at most required sidekiq-poison-pill-remedy, require_relative is rarely ever needed for basic things in gems

Robgra13 · 2024-10-23T21:16:26Z

Job not going to the DeadSet is the problem of testing environment? As you can see I even did puts "1" and so on to check where is exactly is the problem and it points out that failed job is not going to the DeadSet queue. I did this commit to show what I am working on still.
Also difference I have localy is I have Jobs in Queue: 1

Azdaroth

@Robgra13 check if raising an error from the job will help blow it up and have the job available in DeadSet

Azdaroth · 2024-10-24T06:32:09Z

.rubocop.yml

@@ -0,0 +1,8 @@
+Style/Documentation:


@Robgra13 Best to reuse some existing template to have consistency across projects: https://github.com/BookingSync/rails-transactional-outbox/blob/master/.rubocop.yml

Just remember to remove the excluded files which don't exist in this gem ;)

Azdaroth · 2024-10-24T06:32:51Z

Gemfile.lock

@@ -0,0 +1,88 @@
+PATH


@Robgra13 looks like you haven't deleted it

README.md

Azdaroth · 2024-10-24T06:36:52Z

spec/support/my_job.rb

+
+  def perform(arg)
+    if arg == 'fail'
+      Sidekiq.logger.error('Forced failure for testing')


But that will actually be a successful job, no? You would need to raise an error to blow it up

Robgra13 · 2024-10-24T12:56:35Z

So I raised an error and failed job is not hiting the DeadSet. I tried different scenarios of the spec for Testing::fake!, inline! and disable!
I also created job loader to check if it will work with running redis server and sidekiq

Azdaroth · 2024-10-24T13:16:40Z

lib/sidekiq_worker_loader.rb

+require "sidekiq/testing"
+require "rspec-sidekiq"
+require "sidekiq-poison-pill-remedy"
+require_relative "jobs/my_job"


given that this is only for testing, please don't include this on a gem level, but rather on a spec_helper level

Azdaroth · 2024-10-24T13:17:39Z

spec/sidekiq_poison_pill_remedy_spec.rb

+    allow(Sentry).to receive(:capture_message)
+  end
+
+  it "moves job to poison_pill queue and logs message" do


to test this scenario, it would be enough to have any kind of job that could be scheduled by job = MyJob.peform_async(nil) and verify side effects

job = MyJob.peform_async(nil) # assert number of jobs in default queue # assert number of jobs in poison_pill queue SidekiqPoisonPillRemedy.remedy.call(job) # assert number of jobs in default queue # assert number of jobs in poison_pill queue

the side effect should be that in default queue the number of jobs will go from 1 to 0, and for poison pill from 0 to 1.

don't use inline mode, use a test one, to make sure the job will not be processed

README.md

lib/jobs/my_job.rb

Azdaroth

@Robgra13 One last item to address and we are good for the release 💪

Azdaroth · 2024-10-28T18:41:58Z

spec/sidekiq_poison_pill_remedy_spec.rb

+
+      allow_any_instance_of(Sidekiq::DeadSet).to receive(:find_job).with(enqueue_job).and_return(job)
+      allow(Sentry).to receive(:capture_message).and_call_original
+      allow(Sidekiq.logger).to receive(:fatal)


@Robgra13 please always use and_call_original if you use it for the purpose of spying (i.e. using have_received later)

Azdaroth

💪 🐉 Opa!

remedy logic, gemfile, gemspec, CI

3f61386

Robgra13 requested a review from Azdaroth October 9, 2024 16:55

add-platform x86_64-linux

d0bc6ed

Azdaroth reviewed Oct 10, 2024

View reviewed changes

Robgra13 added 4 commits October 10, 2024 17:38

changes according to review, rubocop, readme

014f1b0

gemspec edit

ed404b5

spec edit

8b20c9e

changes in spec

2d4e506

Azdaroth reviewed Oct 24, 2024

View reviewed changes

another spec version

f1a192e

Azdaroth reviewed Oct 24, 2024

View reviewed changes

Robgra13 and others added 4 commits October 24, 2024 17:10

spec changed according to last comment

20e5c7f

write basic specs ; clean up setup and file structure

35264bc

Sentry message

617268a

Sentry spec fix

d57952d

Azdaroth reviewed Oct 25, 2024

View reviewed changes

README.md Show resolved Hide resolved

lib/jobs/my_job.rb Outdated Show resolved Hide resolved

Robgra13 added 2 commits October 28, 2024 11:24

added logging test

2d31831

readme edit, lib/jobs delete

8096821

Azdaroth reviewed Oct 28, 2024

View reviewed changes

and_call_original fix in spec

e348920

Azdaroth approved these changes Oct 29, 2024

View reviewed changes

Azdaroth merged commit c6f27b0 into master Oct 29, 2024
8 checks passed

Azdaroth deleted the gem-edit branch October 29, 2024 07:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remedy logic, gemfile, gemspec, CI #1

remedy logic, gemfile, gemspec, CI #1

Robgra13 commented Oct 9, 2024

Robgra13 commented Oct 9, 2024

Azdaroth Oct 10, 2024 •

edited

Loading

Azdaroth Oct 10, 2024

Azdaroth Oct 24, 2024

Azdaroth Oct 10, 2024

Robgra13 Oct 10, 2024

Azdaroth Oct 10, 2024

Azdaroth Oct 10, 2024

Azdaroth Oct 10, 2024

Azdaroth Oct 10, 2024

Azdaroth Oct 10, 2024

Azdaroth Oct 10, 2024

Robgra13 commented Oct 23, 2024 •

edited

Loading

Azdaroth left a comment

Azdaroth Oct 24, 2024

Azdaroth Oct 24, 2024

Azdaroth Oct 24, 2024

Azdaroth Oct 24, 2024

Robgra13 commented Oct 24, 2024

Azdaroth Oct 24, 2024

Azdaroth Oct 24, 2024

Azdaroth left a comment

Azdaroth Oct 28, 2024

Azdaroth left a comment

		@@ -0,0 +1,41 @@
		# frozen_string_literal: true

		require_relative "../lib/remedy/version"

remedy logic, gemfile, gemspec, CI #1

remedy logic, gemfile, gemspec, CI #1

Conversation

Robgra13 commented Oct 9, 2024

Robgra13 commented Oct 9, 2024

Azdaroth Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Robgra13 commented Oct 23, 2024 • edited Loading

Azdaroth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Robgra13 commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Azdaroth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Azdaroth left a comment

Choose a reason for hiding this comment

Azdaroth Oct 10, 2024 •

edited

Loading

Robgra13 commented Oct 23, 2024 •

edited

Loading