Update dockerfile #2
Conversation
README.md
Outdated
| @@ -1,61 +1,48 @@ | |||
| # DockerIt | |||
| Use Docker containers for tests and code validation! | |||
| # persistent-home-docker | |||
There was a problem hiding this comment.
You might want to update the repository name in this readme, as well as its description.
README.md
Outdated
| --- | ||
| ## Tip | ||
|
|
||
| I find extremely useful to keep a docker monitor running in a separate terminal |
There was a problem hiding this comment.
Suggestion for replacing the sentence in 1st person:
It might be helpful to have a terminal gathering all relevant information for the docker user such as the images, the running, and the stopped containers.
|
|
||
| --- | ||
| ## References | ||
| - http://wiki.ros.org/docker/Tutorials/GUI |
There was a problem hiding this comment.
It could be helpful for newcomers to have a link to docker commands in this documentation so that they know at least those ones:
| Command | Description |
|---|---|
| docker rm | Remove one or more containers |
| docker rmi | Remove one or more images |
I am not sure how we can include this information in the readme. Do you have any suggestions?
|
|
||
| docker run -it \ | ||
| --rm \ | ||
| --volume $(pwd)/home:/home/docker \ |
There was a problem hiding this comment.
@brschettini , this part defines folder persistency (the map between host and container folders).
There was a problem hiding this comment.
what is the purpose of this change? Why are we using this project? The default package for projects is docker autoproj.
Why are we removing files to run ros gazebo 9 on bionic distro with nvidia? And what is the purpose is to use foxy with bionic the suitable distro for foxy is 20.4 or 22.4.
Update dockerfile from @hbaqueiro suggestions