Update 404 page #122
Update 404 page #122
Conversation
✅ Deploy Preview for fanciful-lamington-ea5ee2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/app/not-found.tsx
Outdated
| </div> | ||
| <a | ||
| href="/" | ||
| className="px-5 py-2 my-6 text-base rounded-xl inline-block font-bold transition-all bg-breadviolet-shaded dark:bg-breadpink-shaded text-breadgray-ultra-white dark:text-breadgray-og-dark disabled:bg-opacity-60" |
There was a problem hiding this comment.
I combined all the relevant button classes to achieve this with an<a> tag since its just a link to home page -- but not sure if there's a better way to have done this
There was a problem hiding this comment.
Looks good although there is a reusable <Button> component in core/components and I think the styles are the same.
I'd probably suggest sharing the styles and exporting a <ButtonLink> component from the same file so it's in the same place if styles change.
There was a problem hiding this comment.
yup, sounds right!
I made a new ButtonLink component which just imports things already defined in Button, but renders an a tag.
I'm blocked from merging until you post an approval on a review - can you take a quick look at my latest changes and if approve if all looks good?
There was a problem hiding this comment.
@subject026 whoops, remembered the process is just to merge to dev. will do that now!
|
This was reviewed on today's design call and given approvals for moving forward. @subject026 can you review this PR and let me know and advice/feedback you have on the code? |
[#57]