Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of the "learning rate" parameter of the background subtractor #158

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

felixscheffer
Copy link
Contributor

Adds a parameter called 'learning-rate' to the config file to set the 'learning rate' value of the background subtractor.

@Breakthrough Breakthrough self-requested a review April 12, 2024 01:55
@Breakthrough
Copy link
Owner

Breakthrough commented Apr 12, 2024

Hi @felixscheffer, could you please fix the formatting before submission, and also rebase this PR onto the develop branch?

You can run python -m yapf --diff -r dvr_scan/ to view the errors or python -m yapf -i -r dvr_scan/ to fix the files in-place (or see the build output for the change).

Thank you for the PR!

@felixscheffer felixscheffer changed the base branch from main to develop April 12, 2024 11:17
@felixscheffer felixscheffer changed the base branch from develop to main April 12, 2024 11:18
@felixscheffer felixscheffer force-pushed the expose-learning-rate branch 2 times, most recently from 0567ccc to fd792ca Compare April 12, 2024 12:57
@felixscheffer felixscheffer changed the base branch from main to develop April 12, 2024 13:01
@felixscheffer
Copy link
Contributor Author

Hi @Breakthrough

I updated the formatting and rebased the branch onto the develop branch

Copy link
Owner

@Breakthrough Breakthrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@Breakthrough Breakthrough merged commit 9182c0a into Breakthrough:develop Apr 12, 2024
1 check failed
@Breakthrough Breakthrough added this to the v1.6.1 milestone Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants