Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[detectors] Fix not compensating for filter buffer length #420

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

Breakthrough
Copy link
Owner

With the new flash filter, cuts may be placed behind the current frame.

This is similar to AdaptiveDetector, but when the new filter was landed, the max look behind property of the detector wasn't updated. Fixes #416.

With the new flash filter, cuts may be placed behind the current frame.

This is similar to AdaptiveDetector, but when the new filter was landed,
the max look behind property of the detector wasn't updated. Fixes #416.
@Breakthrough Breakthrough self-assigned this Sep 29, 2024
@Breakthrough Breakthrough added this to the 0.6.5 milestone Sep 29, 2024
@wjs018
Copy link
Collaborator

wjs018 commented Oct 5, 2024

Another part of the codebase I am not super familiar with, but I think I got myself up to speed. Basically, the ContentDetector (and, by inheritance, the AdaptiveDetector) sets the min_scene_len which is then passed on to the FlashFilter as the max_behind property. This is then used to define the event_buffer_length property for the detector. This corrects the problem in #416 where that property isn't overriden from the default of 0.

@Breakthrough Breakthrough merged commit 08eb26e into main Oct 6, 2024
36 checks passed
@Breakthrough
Copy link
Owner Author

Many thanks for the review @wjs018

@Breakthrough Breakthrough deleted the issue-416 branch November 11, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect_scenes seems to fail when used with callback
2 participants