-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working idea for Generic Mapper #1164
Draft
holytshirt
wants to merge
2
commits into
master
Choose a base branch
from
genericmapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holytshirt
force-pushed
the
genericmapper
branch
from
June 17, 2020 14:46
8c50357
to
5d521e8
Compare
holytshirt
force-pushed
the
genericmapper
branch
2 times, most recently
from
February 7, 2022 15:45
64b67c9
to
8856ee8
Compare
holytshirt
force-pushed
the
genericmapper
branch
from
November 9, 2022 22:32
75f95d1
to
f1bedc4
Compare
holytshirt
force-pushed
the
genericmapper
branch
from
June 13, 2023 16:40
f1bedc4
to
7b902e0
Compare
@preardon Is this now done and redundant with your work? |
@iancooper yeah I would say the initial version of this is in |
@holytshirt So as @preardon has a version of this in (sure Paul can explain how it works), I think we should close this PR. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.