Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Payloads #2459

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Binary Payloads #2459

merged 5 commits into from
Jan 5, 2023

Conversation

iancooper
Copy link
Member

There are some issues around binary payloads, such as those expressed in #2458

This PR is about the following:

  • Move Kafka to use a byte[] payload not a UTF-8 string as this will corrupt Kafka header bytes on the payload when used for schema id
  • Add an explicit character encoding to the body, so that we know the character encoding of the string supplied, or can ask that any string created is in a format. Add a helper method to display in a different format
  • Fix how we write to DynamoDb, which needs a Base64 string when storing binary data and not the UTF8 string we give it.

@iancooper iancooper requested a review from holytshirt as a code owner January 5, 2023 19:19
@iancooper iancooper self-assigned this Jan 5, 2023
@iancooper iancooper requested a review from DevJonny as a code owner January 5, 2023 19:19
@iancooper iancooper marked this pull request as draft January 5, 2023 19:19
@iancooper iancooper marked this pull request as ready for review January 5, 2023 19:46
@iancooper iancooper merged commit 1caab1f into master Jan 5, 2023
@iancooper iancooper deleted the binary_payloads branch January 6, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant