Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure RabbitMq continuation timeout #2879

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Configure RabbitMq continuation timeout #2879

merged 2 commits into from
Oct 22, 2023

Conversation

dsquadcgi
Copy link
Contributor

Small pull request to permit the configuration of RabbitMq continuation timeout.

The default value configured by RabbitMq can be too low for some use cases, resulting in TimeoutException.

{
  "@t": "2023-10-13T10:42:21.2540140Z",
  "@mt": "exception capturée par polly, attente de {Secondes} avant réessai ({NbEssai}/{NbEssaiTotal})",
  "@l": "Warning",
  "@x": "System.TimeoutException: The operation has timed out.\n   at RabbitMQ.Client.Impl.SimpleBlockingRpcContinuation.GetReply(TimeSpan timeout)\n   at RabbitMQ.Client.Impl.ModelBase.ModelRpc(MethodBase method, ContentHeaderBase header, Byte[] body)\n   at RabbitMQ.Client.Framing.Impl.Model._Private_ConfirmSelect(Boolean nowait)\n   at RabbitMQ.Client.Impl.ModelBase.ConfirmSelect()\n   at RabbitMQ.Client.Impl.AutorecoveringModel.ConfirmSelect()\n   at Paramore.Brighter.MessagingGateway.RMQ.RmqMessageProducer.SendWithDelay(Message message, Int32 delayMilliseconds) in /_/src/Paramore.Brighter.MessagingGateway.RMQ/RmqMessageProducer.cs:line 133\n   at Paramore.Brighter.MessagingGateway.RMQ.RmqMessageProducer.Send(Message message) in /_/src/Paramore.Brighter.MessagingGateway.RMQ/RmqMessageProducer.cs:line 110\n   at Paramore.Brighter.ExternalBusServices.<>c__DisplayClass49_1.<Dispatch>b__0() in /_/src/Paramore.Brighter/ExternalBusServices.cs:line 382\n   at Polly.Policy.<>c__DisplayClass138_0.<Implementation>b__0(Context ctx, CancellationToken token)\n   at Polly.Retry.RetryEngine.Implementation[TResult](Func`3 action, Context context, CancellationToken cancellationToken, ExceptionPredicates shouldRetryExceptionPredicates, ResultPredicates`1 shouldRetryResultPredicates, Action`4 onRetry, Int32 permittedRetryCount, IEnumerable`1 sleepDurationsEnumerable, Func`4 sleepDurationProvider)",
  "Secondes": 2,
  "NbEssai": 1,
  "NbEssaiTotal": 5,
  "appid": "relations-messagerie"
}

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iancooper
❌ BenjaminSchmitt
You have signed the CLA already but the status is still pending? Let us recheck it.

@iancooper
Copy link
Member

@dsquadcgi Thanks for this. I'll get a release out ASAP

@iancooper iancooper merged commit a574fec into BrighterCommand:master Oct 22, 2023
2 of 3 checks passed
@iancooper
Copy link
Member

@dsquadcgi Should be in 9.7.4

@dsquadcgi
Copy link
Contributor Author

@iancooper thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants