Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a DateTime to a string representation with millisecond accuracy #2945

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

SteveBush
Copy link
Contributor

#2944 . In Sqlite implementation, the timestamp has only second precision. as it was using "s". Convert it to a dateime format with millisecond accuracy.

Note, I chose not to convert it here to UniversalTime(). Dispatch converts to universal time so maybe we should be consistent here.

DispatchedAt?.ToUniversalTime()

@SteveBush
Copy link
Contributor Author

Note, you will need to merge in #2941 before the tests will succceed.

@iancooper
Copy link
Member

As this changes the format of a datetime string, I will probably push this to V10 as we can document the change

@SteveBush
Copy link
Contributor Author

As this changes the format of a datetime string, I will probably push this to V10 as we can document the change

Sounds good. To be specific, the consumer format of datetime does not change just the precision and format that is stored in the database internally. DateTime has an accuracy of 10ms to 30ms depending on OS and computer. Unless the consumer is looking at the database directly, they will only see a change in the accuracy of DateTime.

@iancooper iancooper merged commit 406c280 into BrighterCommand:master Dec 12, 2023
17 of 19 checks passed
@SteveBush SteveBush deleted the bug-2944 branch December 13, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants