Improve support to AWS SQS/SNS #3437

lillo42 · 2024-12-22T17:03:20Z

Hohohoho 🎅

Add support to SNS/SQS FIFO
Improve support for LocalStack
Rename some classes from Sqs to Sns (breaking changes)
Add support to SQS publication
Add Sample for SQS publication & FIFO

~~How should I handle the tests? My current approach is to duplicate them. Should I continue on this path?~~
Duplicate the test

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.12 (9.65 -> 9.53)

Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.10 (9.46 -> 9.36)

Declining Code Health: 8 findings(s) 🚩

View detailed results in CodeScene

iancooper · 2024-12-22T17:27:50Z

Hi @lillo42 - thanks for this. To lift out of inline above, the usual strategy would be:

Folders for each queue type:

Standard
Fifo

Put the existing tests in Standard and duplicate the tests in Fifo, but with the changed semantics.

I tend to prefer being explicit in tests, over worrying about duplication there.

iancooper · 2024-12-22T17:29:24Z

PS @lillo42 if you have time. One weakness in Brighter is that you have to produce to SNS and can't target a queue. It would be good to allow the queue to be the target. We now do something similar for ASB. Probably pop that in a separate PR though?

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.05 (9.61 -> 9.66)

Declining Code Health: 6 findings(s) 🚩

View detailed results in CodeScene

iancooper

This looks great. You may also need to support async approaches, you'll note the increased footprint when you merge in master. It is a little crude, as we just tend to duplicate in tests, but I sort of prefer tests to be explicit

tests/Paramore.Brighter.AWS.Tests/MessagingGateway/When_infastructure_exists_can_assume.cs

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.10 (9.50 -> 9.60)

Declining Code Health: 5 findings(s) 🚩

View detailed results in CodeScene

lillo42 · 2024-12-30T18:45:08Z

PS @lillo42 if you have time. One weakness in Brighter is that you have to produce to SNS and can't target a queue. It would be good to allow the queue to be the target. We now do something similar for ASB. Probably pop that in a separate PR though?

Sure no problem, I can add it to this PR.

iancooper · 2024-12-30T18:54:57Z

Thanks @lillo42. Apologies in advance for the merge issues caused by the Reactor(Blocking)/Proactor(Non-Blocking) enhancement

… localstack and rename SQS to SNS

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.05 (9.60 -> 9.65)

Declining Code Health: 5 findings(s) 🚩

View detailed results in CodeScene

iancooper · 2025-01-02T11:47:04Z

We still have a credentials issue on the AWS tests, that means they don't show up here. I need to fix that too. Let me see if I can fix that and merge to main, so that we can at least see what is passing

iancooper · 2025-01-02T17:07:14Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+        RoutingKey topic,
+        TopicFindBy topicFindBy,
+        SnsAttributes? attributes,
+        OnMissingChannel makeTopic = OnMissingChannel.Create,


Can we make makeTopic the last parameter? That keeps it in sync with other producers

src/Paramore.Brighter.MessagingGateway.AWSSQS/SnsMessageProducer.cs

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageConsumer.cs

iancooper · 2025-01-02T17:13:54Z

src/Paramore.Brighter/CodeAnalysis/MemberNotNullWhenAttribute.cs

+namespace System.Diagnostics.CodeAnalysis;
+
+[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property, Inherited = false, AllowMultiple = true)]
+public sealed class MemberNotNullWhenAttribute : Attribute


Out of interest, we have an open conversation on using polyfills vs dropping netstandard20

I tend to prefer drop support for netstandard20, but depending on how many downloads we have today on .NET standard maybe we still have people using Brighter with .NET Framework 4

Maybe on V11 we can remove the support for .NET Standard completed, and put a warning on V10 saying that is the last version of supporting .NET Standard/Framework

Yeah, you may be right that it would be 0-warning if we dropped it with V10 and we should declare that will happen with V11.

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.13 (9.61 -> 9.74)

Declining Code Health: 9 findings(s) 🚩
Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

codescene-delta-analysis · 2025-01-03T08:46:35Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsInlineMessageCreator.cs

+    public Message CreateMessage(Amazon.SQS.Model.Message sqsMessage)
+    {
+        var topic = HeaderResult<RoutingKey>.Empty();
+        var messageId = HeaderResult<string?>.Empty();
+
+        Message message;
+        try


❌ Getting worse: Complex Method
CreateMessage increases in cyclomatic complexity from 10 to 12, threshold = 9

_Suppress

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessagePublisher.cs

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.43 (9.42 -> 9.85)

Declining Code Health: 10 findings(s) 🚩
Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

codescene-delta-analysis · 2025-01-03T17:01:25Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageCreator.cs


-        public Message CreateMessage(Amazon.SQS.Model.Message sqsMessage)


❌ Getting worse: Complex Method
CreateMessage increases in cyclomatic complexity from 10 to 13, threshold = 9

_Suppress

codescene-delta-analysis · 2025-01-03T17:01:26Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+        RoutingKey topic,
+        TopicFindBy topicFindBy,
+        SnsAttributes? attributes,
+        OnMissingChannel makeTopic = OnMissingChannel.Create,


❌ New issue: Code Duplication
The module contains 2 functions with similar structure: EnsureQueueAsync,EnsureTopicAsync

_Suppress

codescene-delta-analysis · 2025-01-03T17:01:27Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+    private async Task<string> CreateQueueAsync(
+        string queueName,
+        SqsAttributes? sqsAttributes,
+        OnMissingChannel makeChannel,
+        CancellationToken cancellationToken)


❌ New issue: Complex Method
CreateQueueAsync has a cyclomatic complexity of 17, threshold = 9

_Suppress

codescene-delta-analysis · 2025-01-03T17:01:27Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+    private async Task<string> CreateDeadLetterQueueAsync(
+        SqsAttributes sqsAttributes,
+        CancellationToken cancellationToken)
+    {
+        using var sqsClient = _awsClientFactory.CreateSqsClient();
+
+        var queueName = sqsAttributes.RedrivePolicy!.DeadlLetterQueueName;
+
+        var tags = new Dictionary<string, string> { { "Source", "Brighter" } };
+        var attributes = new Dictionary<string, string?>();
+        if (sqsAttributes.Type == SnsSqsType.Fifo)
+        {
+            queueName = queueName.ToValidSQSQueueName(true);
+
+            attributes.Add(QueueAttributeName.FifoQueue, "true");
+            if (sqsAttributes.ContentBasedDeduplication)
+            {
+                attributes.Add(QueueAttributeName.ContentBasedDeduplication, "true");
+            }
+
+            if (sqsAttributes is { DeduplicationScope: not null, FifoThroughputLimit: not null })
+            {
+                attributes.Add(QueueAttributeName.FifoThroughputLimit,
+                    sqsAttributes.FifoThroughputLimit.Value.ToString());
+                attributes.Add(QueueAttributeName.DeduplicationScope, sqsAttributes.DeduplicationScope switch
+                {
+                    DeduplicationScope.MessageGroup => "messageGroup",
+                    _ => "queue"
+                });
+            }
+        }
+
+        string queueUrl;
+
+        try
+        {
+            var request = new CreateQueueRequest(queueName) { Attributes = attributes, Tags = tags };
+            // create queue is idempotent, so safe to call even if queue already exists
+            var response = await sqsClient.CreateQueueAsync(request, cancellationToken);
+
+            queueUrl = response.QueueUrl ?? throw new InvalidOperationException(
+                $"Could not find create DLQ, status: {response.HttpStatusCode}");
+        }
+        catch (QueueNameExistsException)
+        {
+            var response = await sqsClient.GetQueueUrlAsync(queueName, cancellationToken);
+            queueUrl = response.QueueUrl;
+        }
+
+        var attributesResponse = await sqsClient.GetQueueAttributesAsync(
+            new GetQueueAttributesRequest { QueueUrl = queueUrl, AttributeNames = [QueueAttributeName.QueueArn] },
+            cancellationToken);
+
+        if (attributesResponse.HttpStatusCode != HttpStatusCode.OK)
+        {
+            throw new InvalidOperationException(
+                $"Could not find ARN of DLQ, status: {attributesResponse.HttpStatusCode}");
+        }
+
+        return attributesResponse.QueueARN;
+    }


❌ New issue: Complex Method
CreateDeadLetterQueueAsync has a cyclomatic complexity of 10, threshold = 9

_Suppress

codescene-delta-analysis · 2025-01-03T17:01:27Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+    private async Task<string> CreateQueueAsync(
+        string queueName,
+        SqsAttributes? sqsAttributes,
+        OnMissingChannel makeChannel,
+        CancellationToken cancellationToken)


❌ New issue: Bumpy Road Ahead
CreateQueueAsync has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

_Suppress

codescene-delta-analysis · 2025-01-03T17:01:30Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/AWSMessagingGateway.cs

+    private async Task SubscribeToTopicAsync(
+        string topicArn,
+        string queueUrl,
+        SqsAttributes? sqsAttributes,
+        AmazonSQSClient sqsClient,
+        AmazonSimpleNotificationServiceClient snsClient)
+    {
+        var arn = await snsClient.SubscribeQueueAsync(topicArn, sqsClient, queueUrl);
+        if (string.IsNullOrEmpty(arn))
+        {
+            throw new InvalidOperationException(
+                $"Could not subscribe to topic: {topicArn} from queue: {queueUrl} in region {AwsConnection.Region}");
+        }
+
+        var response = await snsClient.SetSubscriptionAttributesAsync(
+            new SetSubscriptionAttributesRequest(arn,
+                "RawMessageDelivery",
+                sqsAttributes?.RawMessageDelivery.ToString())
+        );
+
+        if (response.HttpStatusCode != HttpStatusCode.OK)
+        {
+            throw new InvalidOperationException("Unable to set subscription attribute for raw message delivery");
+        }
+    }


ℹ New issue: Excess Number of Function Arguments
SubscribeToTopicAsync has 5 arguments, threshold = 4

src/Paramore.Brighter.MessagingGateway.AWSSQS/ChannelFactory.cs

iancooper

There is a lot here, and it is a great addition. A couple of minor tweaks, which are more o do with style over anything else.

src/Paramore.Brighter.MessagingGateway.AWSSQS/SnsMessageProducer.cs

iancooper · 2025-01-03T17:13:16Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsInlineMessageCreator.cs

-
-            var arnElements = s!.Split(':');
-            var topic = arnElements[(int)ARNAmazonSNS.TopicName];
+            var topic = topicArn.GetValueInString() ?? string.Empty;


The earlier version reduces nesting by returning early, which is generally preferable

iancooper · 2025-01-03T17:20:34Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageSender.cs

+            }
+        }
+
+        var messageAttributes = new Dictionary<string, MessageAttributeValue>


Typically we factor this into a publisher, to keep the producer clean of all the header manipulation

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.38 (9.48 -> 9.86)

Declining Code Health: 8 findings(s) 🚩
Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

src/Paramore.Brighter.MessagingGateway.AWSSQS/RoutingKeyType.cs

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.38 (9.48 -> 9.86)

Declining Code Health: 8 findings(s) 🚩
Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

codescene-delta-analysis · 2025-01-06T09:37:47Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsSubscription.cs

+    public SqsSubscription(
+        SubscriptionName? name = null,
+        ChannelName? channelName = null,
+        RoutingKey? routingKey = null,
+        int bufferSize = 1,
+        int noOfPerformers = 1,
+        TimeSpan? timeOut = null,
+        int requeueCount = -1,
+        TimeSpan? requeueDelay = null,
+        int unacceptableMessageLimit = 0,
+        MessagePumpType messagePumpType = MessagePumpType.Proactor,
+        IAmAChannelFactory? channelFactory = null,
+        int lockTimeout = 10,
+        int delaySeconds = 0,
+        int messageRetentionPeriod = 345600,
+        TopicFindBy findTopicBy = TopicFindBy.Name,
+        string? iAmPolicy = null,
+        RedrivePolicy? redrivePolicy = null,
+        SnsAttributes? snsAttributes = null,
+        Dictionary<string, string>? tags = null,
+        OnMissingChannel makeChannels = OnMissingChannel.Create,
+        bool rawMessageDelivery = true,
+        TimeSpan? emptyChannelDelay = null,
+        TimeSpan? channelFailureDelay = null,
+        SnsSqsType sqsType = SnsSqsType.Standard,
+        bool contentBasedDeduplication = true,
+        DeduplicationScope? deduplicationScope = null,
+        int? fifoThroughputLimit = null,
+        ChannelType channelType = ChannelType.PubSub,
+        QueueFindBy findQueueBy = QueueFindBy.Name
+    )
+        : base(typeof(T), name, channelName, routingKey, bufferSize, noOfPerformers, timeOut, requeueCount,
+            requeueDelay,
+            unacceptableMessageLimit, messagePumpType, channelFactory, lockTimeout, delaySeconds,
+            messageRetentionPeriod, findTopicBy,
+            iAmPolicy, redrivePolicy, snsAttributes, tags, makeChannels, rawMessageDelivery, emptyChannelDelay,
+            channelFailureDelay, sqsType, contentBasedDeduplication, deduplicationScope, fifoThroughputLimit,
+            channelType, findQueueBy)


ℹ Getting worse: Constructor Over-Injection
SqsSubscription increases from 23 to 29 arguments, threshold = 5

lillo42 · 2025-01-06T09:58:19Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageSender.cs

+        if (delay != null)
+        {
+            request.DelaySeconds = (int)delay.Value.TotalSeconds;
+        }
+


@iancooper question about DelaySeconds AWS SQS supports max of 15min, should I add an extra logic to support longer delay? Or let it throw?

Just to confirm our conversation, reduce to max, and log that it was reduced.

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.38 (9.48 -> 9.86)

Declining Code Health: 10 findings(s) 🚩
Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

codescene-delta-analysis · 2025-01-07T08:55:35Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsSubscription.cs

+    public SqsSubscription(
+        Type dataType,
+        SubscriptionName? name = null,
+        ChannelName? channelName = null,
+        RoutingKey? routingKey = null,
+        int bufferSize = 1,
+        int noOfPerformers = 1,
+        TimeSpan? timeOut = null,
+        int requeueCount = -1,
+        TimeSpan? requeueDelay = null,
+        int unacceptableMessageLimit = 0,
+        MessagePumpType messagePumpType = MessagePumpType.Unknown,
+        IAmAChannelFactory? channelFactory = null,
+        int lockTimeout = 10,
+        int delaySeconds = 0,
+        int messageRetentionPeriod = 345600,
+        TopicFindBy findTopicBy = TopicFindBy.Name,
+        string? iAmPolicy = null,
+        RedrivePolicy? redrivePolicy = null,
+        SnsAttributes? snsAttributes = null,
+        Dictionary<string, string>? tags = null,
+        OnMissingChannel makeChannels = OnMissingChannel.Create,
+        bool rawMessageDelivery = true,
+        TimeSpan? emptyChannelDelay = null,
+        TimeSpan? channelFailureDelay = null,
+        SnsSqsType sqsType = SnsSqsType.Standard,
+        bool contentBasedDeduplication = true,
+        DeduplicationScope? deduplicationScope = null,
+        int? fifoThroughputLimit = null,
+        ChannelType channelType = ChannelType.PubSub,
+        QueueFindBy findQueueBy = QueueFindBy.Name
+    )
+        : base(dataType, name, channelName, routingKey, bufferSize, noOfPerformers, timeOut, requeueCount,
+            requeueDelay, unacceptableMessageLimit, messagePumpType, channelFactory, makeChannels, emptyChannelDelay,
+            channelFailureDelay)


ℹ Getting worse: Constructor Over-Injection
SqsSubscription increases from 24 to 30 arguments, threshold = 5

codescene-delta-analysis · 2025-01-07T08:55:35Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageSender.cs

+    public async Task<string?> SendAsync(Message message, TimeSpan? delay, CancellationToken cancellationToken)
+    {
+        var request = new SendMessageRequest
+        {
+            QueueUrl = _queueUrl, 
+            MessageBody = message.Body.Value
+        };
+
+        delay ??= TimeSpan.Zero;
+        if (delay > TimeSpan.Zero)
+        {
+            // SQS has a hard limit of 15min for Delay in Seconds
+            if (delay.Value > s_maxDelay)
+            {
+                delay = s_maxDelay;
+                s_logger.LogWarning("Set delay from {CurrentDelay} to 15min (SQS support up to 15min)", delay);
+            }
+
+            request.DelaySeconds = (int)delay.Value.TotalSeconds;
+        }
+
+        if (_queueType == SnsSqsType.Fifo)
+        {
+            request.MessageGroupId = message.Header.PartitionKey;
+            if (message.Header.Bag.TryGetValue(HeaderNames.DeduplicationId, out var deduplicationId))
+            {
+                request.MessageDeduplicationId = (string)deduplicationId;
+            }
+        }
+
+        var messageAttributes = new Dictionary<string, MessageAttributeValue>
+        {
+            [HeaderNames.Id] =
+                new() { StringValue = message.Header.MessageId, DataType = "String" },
+            [HeaderNames.Topic] = new() { StringValue = _queueUrl, DataType = "String" },
+            [HeaderNames.ContentType] = new() { StringValue = message.Header.ContentType, DataType = "String" },
+            [HeaderNames.CorrelationId] =
+                new() { StringValue = message.Header.CorrelationId, DataType = "String" },
+            [HeaderNames.HandledCount] =
+                new() { StringValue = Convert.ToString(message.Header.HandledCount), DataType = "String" },
+            [HeaderNames.MessageType] =
+                new() { StringValue = message.Header.MessageType.ToString(), DataType = "String" },
+            [HeaderNames.Timestamp] = new()
+            {
+                StringValue = Convert.ToString(message.Header.TimeStamp), DataType = "String"
+            }
+        };
+
+        if (!string.IsNullOrEmpty(message.Header.ReplyTo))
+        {
+            messageAttributes.Add(HeaderNames.ReplyTo,
+                new MessageAttributeValue { StringValue = message.Header.ReplyTo, DataType = "String" });
+        }
+
+        if (!string.IsNullOrEmpty(message.Header.Subject))
+        {
+            messageAttributes.Add(HeaderNames.Subject,
+                new MessageAttributeValue { StringValue = message.Header.Subject, DataType = "String" });
+        }
+
+        // we can set up to 10 attributes; we have set 6 above, so use a single JSON object as the bag
+        var bagJson = JsonSerializer.Serialize(message.Header.Bag, JsonSerialisationOptions.Options);
+        messageAttributes[HeaderNames.Bag] = new() { StringValue = bagJson, DataType = "String" };
+        request.MessageAttributes = messageAttributes;
+
+        var response = await _client.SendMessageAsync(request, cancellationToken);
+        if (response.HttpStatusCode is HttpStatusCode.OK or HttpStatusCode.Created
+            or HttpStatusCode.Accepted)
+        {
+            return response.MessageId;
+        }
+
+        return null;
+    }


❌ New issue: Complex Method
SendAsync has a cyclomatic complexity of 9, threshold = 9

_Suppress

codescene-delta-analysis · 2025-01-07T08:55:36Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageSender.cs

+    public async Task<string?> SendAsync(Message message, TimeSpan? delay, CancellationToken cancellationToken)
+    {
+        var request = new SendMessageRequest
+        {
+            QueueUrl = _queueUrl, 
+            MessageBody = message.Body.Value
+        };
+
+        delay ??= TimeSpan.Zero;
+        if (delay > TimeSpan.Zero)
+        {
+            // SQS has a hard limit of 15min for Delay in Seconds
+            if (delay.Value > s_maxDelay)
+            {
+                delay = s_maxDelay;
+                s_logger.LogWarning("Set delay from {CurrentDelay} to 15min (SQS support up to 15min)", delay);
+            }
+
+            request.DelaySeconds = (int)delay.Value.TotalSeconds;
+        }
+
+        if (_queueType == SnsSqsType.Fifo)
+        {
+            request.MessageGroupId = message.Header.PartitionKey;
+            if (message.Header.Bag.TryGetValue(HeaderNames.DeduplicationId, out var deduplicationId))
+            {
+                request.MessageDeduplicationId = (string)deduplicationId;
+            }
+        }
+
+        var messageAttributes = new Dictionary<string, MessageAttributeValue>
+        {
+            [HeaderNames.Id] =
+                new() { StringValue = message.Header.MessageId, DataType = "String" },
+            [HeaderNames.Topic] = new() { StringValue = _queueUrl, DataType = "String" },
+            [HeaderNames.ContentType] = new() { StringValue = message.Header.ContentType, DataType = "String" },
+            [HeaderNames.CorrelationId] =
+                new() { StringValue = message.Header.CorrelationId, DataType = "String" },
+            [HeaderNames.HandledCount] =
+                new() { StringValue = Convert.ToString(message.Header.HandledCount), DataType = "String" },
+            [HeaderNames.MessageType] =
+                new() { StringValue = message.Header.MessageType.ToString(), DataType = "String" },
+            [HeaderNames.Timestamp] = new()
+            {
+                StringValue = Convert.ToString(message.Header.TimeStamp), DataType = "String"
+            }
+        };
+
+        if (!string.IsNullOrEmpty(message.Header.ReplyTo))
+        {
+            messageAttributes.Add(HeaderNames.ReplyTo,
+                new MessageAttributeValue { StringValue = message.Header.ReplyTo, DataType = "String" });
+        }
+
+        if (!string.IsNullOrEmpty(message.Header.Subject))
+        {
+            messageAttributes.Add(HeaderNames.Subject,
+                new MessageAttributeValue { StringValue = message.Header.Subject, DataType = "String" });
+        }
+
+        // we can set up to 10 attributes; we have set 6 above, so use a single JSON object as the bag
+        var bagJson = JsonSerializer.Serialize(message.Header.Bag, JsonSerialisationOptions.Options);
+        messageAttributes[HeaderNames.Bag] = new() { StringValue = bagJson, DataType = "String" };
+        request.MessageAttributes = messageAttributes;
+
+        var response = await _client.SendMessageAsync(request, cancellationToken);
+        if (response.HttpStatusCode is HttpStatusCode.OK or HttpStatusCode.Created
+            or HttpStatusCode.Accepted)
+        {
+            return response.MessageId;
+        }
+
+        return null;
+    }


❌ New issue: Bumpy Road Ahead
SendAsync has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

_Suppress

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.38 (9.48 -> 9.86)

Declining Code Health: 10 findings(s) 🚩
Improving Code Health: 5 findings(s) ✅

View detailed results in CodeScene

BrighterCommandGH-1294 Add support to FIFO

1ddd758

lillo42 requested review from iancooper, holytshirt, DevJonny and preardon as code owners December 22, 2024 17:03

codescene-delta-analysis bot reviewed Dec 22, 2024

View reviewed changes

BrighterCommandGH-1294 fixes build

582d57c

codescene-delta-analysis bot reviewed Dec 22, 2024

View reviewed changes

BrighterCommandGH-1294 Add Fifo test

c9e3033

codescene-delta-analysis bot reviewed Dec 29, 2024

View reviewed changes

iancooper reviewed Dec 30, 2024

View reviewed changes

tests/Paramore.Brighter.AWS.Tests/MessagingGateway/When_infastructure_exists_can_assume.cs Outdated Show resolved Hide resolved

lillo42 added 3 commits December 30, 2024 17:04

Merge with master

7a188b5

BrighterCommandGH-1294 fixes unit test

ab9d3e9

BrighterCommandGH-1294 Improve support to LocalStack

c9b7e83

codescene-delta-analysis bot reviewed Dec 30, 2024

View reviewed changes

lillo42 added 5 commits December 31, 2024 14:39

BrighterCommandGH-1294 Use AwsFactory

c94003e

Merge branch 'master' into BrighterCommandGH-1294.add.aws.fifo

9226568

Merge branch 'master' into BrighterCommandGH-1294.add.aws.fifo

849d21f

Merge branch 'master' into BrighterCommandGH-1294.add.aws.fifo

c9b3f7c

BrighterCommandGH-1294 Fixes the majority of test, improve support to…

85db988

… localstack and rename SQS to SNS

codescene-delta-analysis bot reviewed Jan 2, 2025

View reviewed changes

BrighterCommandGH-1294 Fixes http test

e449da8

lillo42 added 2 commits January 2, 2025 15:23

Add Fifo test

527e14a

Merge with master

0cfb765

iancooper reviewed Jan 2, 2025

View reviewed changes

iancooper approved these changes Jan 2, 2025

View reviewed changes

BrighterCommandGH-1294 fixes DLQ, Get System Attribute & Unit tests

11ffdef

codescene-delta-analysis bot reviewed Jan 3, 2025

View reviewed changes

lillo42 added 3 commits January 3, 2025 09:17

BrighterCommandGH-1294 Improve Valid SQS/SNS name logic

75f431b

BrighterCommandGH-1294 Improve Valid SQS/SNS name logic

58a701e

Add support to SQS Publication and add FIFO tests

4299f90

codescene-delta-analysis bot reviewed Jan 3, 2025

View reviewed changes

iancooper reviewed Jan 3, 2025

View reviewed changes

lillo42 added 3 commits January 4, 2025 16:42

Fixes SQS unit tests

e849a3f

BrighterCommandGH-1294 Add Fifo sample

5abb8d6

Improvements

3f02f03

codescene-delta-analysis bot reviewed Jan 5, 2025

View reviewed changes

lillo42 commented Jan 5, 2025

View reviewed changes

src/Paramore.Brighter.MessagingGateway.AWSSQS/RoutingKeyType.cs Outdated Show resolved Hide resolved

lillo42 added 2 commits January 6, 2025 09:25

Rename ChannelType

7a868d7

Merge with master

acbf666

lillo42 changed the title ~~GH-1294 Add support to FIFO~~ Improve support to AWS SQS/SNS Jan 6, 2025

codescene-delta-analysis bot reviewed Jan 6, 2025

View reviewed changes

lillo42 commented Jan 6, 2025

View reviewed changes

lillo42 added 2 commits January 6, 2025 13:27

Set max delay

9d619e4

Merge with master

2c914eb

codescene-delta-analysis bot reviewed Jan 7, 2025

View reviewed changes

Merge with master

c0bb2a4

codescene-delta-analysis bot reviewed Jan 8, 2025

View reviewed changes


		public Message CreateMessage(Amazon.SQS.Model.Message sqsMessage)

Improve support to AWS SQS/SNS #3437

Are you sure you want to change the base?

Improve support to AWS SQS/SNS #3437

Conversation

lillo42 commented Dec 22, 2024 • edited Loading

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

iancooper commented Dec 22, 2024

iancooper commented Dec 22, 2024

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

iancooper left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

lillo42 commented Dec 30, 2024

iancooper commented Dec 30, 2024

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

iancooper commented Jan 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 3, 2025

Choose a reason for hiding this comment

iancooper left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 7, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 7, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Jan 7, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

lillo42 commented Dec 22, 2024 •

edited

Loading