Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-3419 Use JsonSerialisationOptions.Options when use JsonSerializer.Serialize #3463

Merged
merged 3 commits into from
Jan 8, 2025
Merged

GH-3419 Use JsonSerialisationOptions.Options when use JsonSerializer.Serialize #3463

merged 3 commits into from
Jan 8, 2025

Conversation

lillo42
Copy link
Contributor

@lillo42 lillo42 commented Jan 8, 2025

No description provided.

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.28 -> 9.28)

View detailed results in CodeScene

@lillo42 lillo42 changed the title GH-3419 Use sonSerialisationOptions.Options when use JsonSerializer.Serialize GH-3419 Use JsonSerialisationOptions.Options when use JsonSerializer.Serialize Jan 8, 2025
iancooper
iancooper approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@iancooper iancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lillo42

@iancooper
Copy link
Member

iancooper commented Jan 8, 2025 •
edited
Loading

@lillo42 Happy to merge. If we can get a working build...

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Jan 8, 2025
View reviewed changes
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.37 -> 9.37)

View detailed results in CodeScene

@lillo42
Copy link
Contributor Author

lillo42 commented Jan 8, 2025

Wired, all test are passing my local machine (Windows & WSL Ubuntu)

@iancooper
Copy link
Member

Works now, looks like a GitHub issue

@iancooper iancooper merged commit 414f5cc into BrighterCommand:master Jan 8, 2025
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

@iancooper iancooper iancooper approved these changes

@holytshirt holytshirt Awaiting requested review from holytshirt holytshirt is a code owner

@DevJonny DevJonny Awaiting requested review from DevJonny DevJonny is a code owner

@preardon preardon Awaiting requested review from preardon preardon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lillo42 @iancooper