-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow translations to be provided on external media #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for extending or overriding the standard gettext language translations for the canute-ui.
The change will look for a
locale
directory on removable media (SD card or USB drive) containing files such as:de_DE.UTF-8@ueb1/LC_MESSAGES/canute.mo
These should be compiled from the
canute.po
file containing translations, based on the most up to datecanute.pot
template file.When found, each file is checked for a
msgid "Language Name, UEB grade"
entry which should provide the actual language name for that file, in a suitable form for showing in the language and code menu list.If there are duplicate languages with the exact same code, then the files on SD are taken, followed by USB1 & USB2 before finally falling back to the built-in translations supplied with the unit/this repo.
If a state file contains a language code that is no longer available, it will fall back to using
en_GB.UTF-8@ueb2
.If no languages are found on external media then the only effect this PR has is to show the language menu in a different order (it sorts by the language code so
de_DE
is shown beforeen-GB
).Fixes #198