Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: accordion gen2 loopkey #3813

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samijaber
Copy link
Contributor

Description

Identical to #3725. For some reason, the other PR isn't running CI test jobs properly, so I'm making a new PR

Copy link

gitguardian bot commented Jan 8, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9508867 Triggered Generic High Entropy Secret cca4410 packages/react/src/blocks/Video.tsx View secret
314150 Triggered Generic High Entropy Secret cca4410 packages/react/src/blocks/Video.tsx View secret
14200383 Triggered Generic High Entropy Secret cca4410 packages/core/src/builder.class.test.ts View secret
14200385 Triggered Generic High Entropy Secret cca4410 packages/core/src/builder.class.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 676df41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@builder.io/sdk-angular Patch
@builder.io/sdk-qwik Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-native Patch
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Jan 8, 2025

View your CI Pipeline Execution ↗ for commit 676df41.

Command Status Duration Result
nx test @e2e/react-native ❌ Failed 2m 38s View ↗
nx test @snippet/angular-ssr ❌ Failed 2m 7s View ↗
nx test @snippet/react-native ❌ Failed 2m 22s View ↗
nx test @e2e/angular-ssr ❌ Failed 2m 4s View ↗
nx test @e2e/sveltekit ❌ Failed 1m 43s View ↗
nx test @e2e/svelte ❌ Failed 1m 37s View ↗
nx test @e2e/vue ❌ Failed 1m 26s View ↗
nx test @e2e/angular ❌ Failed 1m 39s View ↗
Additional runs (34) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 21:31:19 UTC

@oxcabe
Copy link

oxcabe commented Jan 8, 2025

Thanks for resurrecting the PR!

I'm kind of busy atm but will have a look into the CI logs when possible.

@@ -172,7 +173,7 @@ export default function Accordion(props: AccordionProps) {
<div class="builder-accordion" style={state.accordionStyles}>
<For each={props.items}>
{(item, index) => (
<>
<Fragment key={index}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to update mitosis version for this right? I believe the key for Fragment in React and Solid were introduced in later releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants