-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: accordion gen2 loopkey #3813
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9508867 | Triggered | Generic High Entropy Secret | cca4410 | packages/react/src/blocks/Video.tsx | View secret |
314150 | Triggered | Generic High Entropy Secret | cca4410 | packages/react/src/blocks/Video.tsx | View secret |
14200383 | Triggered | Generic High Entropy Secret | cca4410 | packages/core/src/builder.class.test.ts | View secret |
14200385 | Triggered | Generic High Entropy Secret | cca4410 | packages/core/src/builder.class.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
🦋 Changeset detectedLatest commit: 676df41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 676df41.
☁️ Nx Cloud last updated this comment at |
Thanks for resurrecting the PR! I'm kind of busy atm but will have a look into the CI logs when possible. |
…lder into fix/accordion-gen2-loopkey
@@ -172,7 +173,7 @@ export default function Accordion(props: AccordionProps) { | |||
<div class="builder-accordion" style={state.accordionStyles}> | |||
<For each={props.items}> | |||
{(item, index) => ( | |||
<> | |||
<Fragment key={index}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to update mitosis version for this right? I believe the key
for Fragment in React and Solid were introduced in later releases
Description
Identical to #3725. For some reason, the other PR isn't running CI test jobs properly, so I'm making a new PR