fix/97 - simulation issues #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdsBuildingType with updated value if original building type not found
nllong
reviewed
Dec 16, 2020
| - $SH "bundle exec rspec spec/tests/model_articulation_test/service_hot_water_system_spec.rb" | ||
| - $SH "bundle exec rspec spec/tests/model_articulation_test/site_spec.rb" | ||
| # - $SH "bundle exec rspec spec/tests/model_articulation_test/weather_file_download_spec.rb" // fails sometimes due to connection issues, so we exclude it here | ||
| name: "Model Articulation Tests" | ||
| - script: | ||
| - travis_wait 40 $SH "bundle exec rspec spec/tests/model_articulation_test/hospital_occupancy_type_spec.rb" |
There was a problem hiding this comment.
We are going to run out of travis credits pretty soon. Leave this as-is, but we will need to move over to github actions.
There was a problem hiding this comment.
we are already out...
nllong
reviewed
Dec 16, 2020
| @@ -47,4 +49,29 @@ require 'openstudio/model_articulation' | |||
| rake_task = OpenStudio::Extension::RakeTask.new | |||
| rake_task.set_extension_class(OpenStudio::ModelArticulation::Extension) | |||
|
|
|||
| desc 'Convert tabs to spaces' | |||
| task :remove_tabs do | |||
nllong
reviewed
Dec 16, 2020
| # OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| # ******************************************************************************* | ||
|
|
||
| SCHEMA_2_0_URL = 'https://raw.githubusercontent.com/BuildingSync/schema/v2.0/BuildingSync.xsd' |
There was a problem hiding this comment.
thanks for making these obvious. Is there documentation (in the README) saying to update these when upgrading the version of BuidngSync?
nllong
reviewed
Dec 16, 2020
| return xml_element.text | ||
| end | ||
| return nil | ||
| end | ||
|
|
||
| def help_get_text_value_as_float(xml_element) |
nllong
approved these changes
Dec 16, 2020
…case requirements
|
Still some things outstanding:
Tests failing:model_articulation_test/*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work started for: #97
method(element, ns)->methodby initializing superclasses forLocationElement,SpatialElement, etc.