Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added google login and google drive sync #431

Open
wants to merge 1 commit into
base: bug-fixes
Choose a base branch
from

Conversation

nikhilchowdary
Copy link

@nikhilchowdary nikhilchowdary commented Feb 19, 2017

Issue#395
1.Added google login functionality to get user's credentials :: profile pic , name and email account
2.Added google drive to sync drafts,apks and saved projects to the drive and upon completion of sync user recieve notifications of synced draft/project/apk.
iss395

@nikhilchowdary nikhilchowdary force-pushed the iss395 branch 3 times, most recently from e59662e to 0ca028b Compare February 21, 2017 07:07
@opticod
Copy link
Collaborator

opticod commented Feb 26, 2017

@nikhilchowdary , Thanks for the PR. Its a good feature.

  1. So suppose I have re-installed my app and old data is lost. Can now performing Sync will download the old data?

  2. As this requires google app signing and registration. For now lets remove the source-code/app/google-services.json file from your commit. We will be adding it after adding the project in console.

@nikhilchowdary
Copy link
Author

The sync feature is implemented only to upload the files to drive so that it can be used to manually download files from drive . Should I also include a download files option from the app itself

@opticod
Copy link
Collaborator

opticod commented Feb 26, 2017

Naturally, there should be one option to update the contents of the phone from the cloud side too.

@nikhilchowdary
Copy link
Author

@opticod
ok I will update the PR with download option.

@opticod
Copy link
Collaborator

opticod commented Sep 1, 2017

@nikhilchowdary , are you still on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants