implement clone on automaton states #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
automaton-states-clone
branch
2 times, most recently
from
9ab750d
to
f0f24e4
Compare
MarinPostma
force-pushed
the
automaton-states-clone
branch
from
f0f24e4
to
e6c606b
Compare
|
Hey @BurntSushi, We are awaiting this PR to be merged on the Meilisearch side. It doesn't introduce any breaking change and I am sure the changes that Marin is introducing here are just small oversights that you probably forget about. The library should expose those Could you please take a small look at it? Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements clone for the helper automaton states (
StartWithState,UnionState,IntersectionState, andComplementState), so we can use these automatons withsearch_with_state.I have also made the inner automatons public.