api: add TimeZone::to_fixed_offset
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
to_fixed_offset
branch
from
ac71a8b to
2de06e5
Compare
This adds a new API for converting a `TimeZone` to a fixed offset, but *only* when it's safe to do so (i.e., the time zone is itself just a fixed offset). I'm not a huge fan of adding this API because I feel like it confuses things a bit and could potentially lead to decision paralysis. But I think the use case makes sense (needing to interoperate with Python's datetime system through pyo3, which requires needing to know more about the "type" of a time zone). We also call this out (albeit in more vague terms) in the docs to hopefully warn folks off of it. Closes BurntSushi#169
BurntSushi
force-pushed
the
to_fixed_offset
branch
from
2de06e5 to
6cd7698
Compare
|
Thanks! I've rebased this on master, fixed up the docs and improved the error message a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #169