Fix ISOWeekDate::weekday doc and examples
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ISO-Week is Monday == day 1 based system, it would be nice to give correct example to readers in this context. So instead of `Weekday::to_sunday_zero_offset` use `Weekday::to_monday_one_offset` in doc and examples. Add an assert test into the example code to highlight above. Signed-off-by: 35V LG84 <[email protected]>
BurntSushi
requested changes
Jan 10, 2025
Add `Weekday::to_sunday_zero_offset` into `ISOWeekDate::weekday` doc example tests. Signed-off-by: 35V LG84 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As ISO-Week is Monday == day 1 based system, it would be nice to give correct example to readers in this context.
So instead of
Weekday::to_sunday_zero_offsetuseWeekday::to_monday_one_offsetin doc and examples.Add an assert test into the example code to highlight above.