Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deserialize_any to call visit_none on empty cells #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msrd0
Copy link

@msrd0 msrd0 commented Sep 29, 2021

I'm trying to deserialize Option<chrono::NaiveTime> from inside a custom deserialize implementation that calls deserialize_map and then next_key/next_value with all type info available. Nevertheless, it ends up calling deserialize_any instead of deserialize_option, and then fails to parse on empty cells instead of returning None as I'd expect. This PR allows deserialize_any to treat empty fields as None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant