Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of package id #31

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

septatrix
Copy link
Contributor

Previously the order id was extracted which does not match the cID

Previously the order id was extracted which does not match the cID
@Buxdehuda
Copy link
Owner

This one fails all the previously provided test cases. I honestly don't know if they are still used, but backwards compatability is always nice to have since the page seems to differ greatly depending on the products you bought

@initB10r
Copy link

initB10r commented Feb 6, 2024

This fix worked wonderfully for me. A renew was not possible without it.

@initB10r initB10r mentioned this pull request Feb 6, 2024
@Buxdehuda
Copy link
Owner

@chrstn-hntschl As you we're the last person to provide an example for the package id parsing, can you confirm this change works for you?

@chrstn-hntschl
Copy link

@Buxdehuda Can confirm it works! Thanks a lot for all your efforts !

@Buxdehuda
Copy link
Owner

Good to hear. I deleted the old tests, it probably doesn't make that much sense to check something that changes frequently.
Maybe in the future we could save the successfully parsed cID in a file on a per-domain basis, so that for existing users the script won't break that easily.

Anyway, thanks for adapting the code to reflect the current state of the Strato website design.

@Buxdehuda Buxdehuda merged commit 120caf5 into Buxdehuda:master Feb 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants