Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tasks aware of config context #71

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Make tasks aware of config context #71

merged 6 commits into from
Dec 20, 2024

Conversation

leclairm
Copy link
Contributor

make tasks aware of config root directory, start and end dates.
Also restructure tests to put each in its own directory

make tasks aware of config root directory, start and end dates.
Also restructure tests to put each in its own directory
@leclairm leclairm requested a review from agoscinski December 19, 2024 12:41
Copy link
Collaborator

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already approve. Only one question I am not sure why the tasks have start and end_date? Isn't this something icon specific and should be in the icon task?

@leclairm leclairm merged commit 5608e2e into main Dec 20, 2024
3 checks passed
@leclairm leclairm deleted the config-rootdir branch December 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants