Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minutes for ICON meeting 2024-2 #131

Merged
merged 13 commits into from
Jun 24, 2024
Merged

Add minutes for ICON meeting 2024-2 #131

merged 13 commits into from
Jun 24, 2024

Conversation

AnnikaLau
Copy link
Contributor

No description provided.

@AnnikaLau
Copy link
Contributor Author

@mjaehn @jonasjucker @leclairm : could you check the TODOs in the text: https://github.com/C2SM/c2sm.github.io/blob/minutes_2024-2/events/icon_meetings/2024-2.md. There is at least one little TODO for each of you, where I wasn't sure I followed the conversation correctly.

@mjaehn
Copy link
Contributor

mjaehn commented Jun 21, 2024

Thanks @AnnikaLau, great work! I will complete my TODOs today.

@mjaehn
Copy link
Contributor

mjaehn commented Jun 21, 2024

Done my part: 0b57dfd

@AnnikaLau
Copy link
Contributor Author

Done my part: 0b57dfd

Oh actually there was another one for you, but I accidentally wrote ML. It is in Clarissa's report. Could you please check that also?

@mjaehn
Copy link
Contributor

mjaehn commented Jun 21, 2024

Done my part: 0b57dfd

Oh actually there was another one for you, but I accidentally wrote ML. It is in Clarissa's report. Could you please check that also?

Done 😃

@AnnikaLau
Copy link
Contributor Author

Done my part: 0b57dfd

Oh actually there was another one for you, but I accidentally wrote ML. It is in Clarissa's report. Could you please check that also?

Done 😃

Great, thank you!

@jonasjucker
Copy link
Contributor

done

@AnnikaLau AnnikaLau marked this pull request as ready for review June 24, 2024 07:59
@AnnikaLau AnnikaLau requested a review from mjaehn June 24, 2024 09:55
mjaehn
mjaehn reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnnikaLau!
I will go through this afternoon and also add Will Sawyer's material.

mjaehn
mjaehn approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mjaehn mjaehn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thanks a lot @AnnikaLau et al. for compiling the protocol! 🎉 LGTM

@mjaehn mjaehn merged commit f42e63a into main Jun 24, 2024
2 checks passed
@mjaehn mjaehn deleted the minutes_2024-2 branch June 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjaehn mjaehn mjaehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnikaLau @mjaehn @jonasjucker @leclairm