Open external nav links in new tab by default #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnikaLau
approved these changes
Nov 3, 2023
|
It actually doesn't work... |
|
What exactly does not work? Website LGTM |
|
I thought this merge request should "open external navigation links in new tab". At least for me that's not happening. |
|
This is because we don't have external links in the navigation bar (yet). |
|
Ah, I thought that would apply to any external link. Shouldn't we have that rule for all links? |
|
Yes I would prefer that, too. However, this is not yet implemented in just-the-docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just setting a default value. At the moment, we don't have external links in the navigation bar, so it won't affect the page.
We may think about adding external links to the navigation if needed.