Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure tasks #91

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Restructure tasks #91

merged 14 commits into from
Nov 14, 2023

Conversation

leclairm
Copy link
Contributor

@leclairm leclairm commented Nov 13, 2023 •
edited
Loading

  • merge everything to one page, not enough content for several, also facilitates navigation
  • use details for each submitting procedure
  • shorten WG titles, use description for details
  • some example of WG3 activities missing

@leclairm
ref(tasks): restructure tasks
5a7e7f4 
- [x] merge everything to one page, not enough content for several,
  also facilitates navigation
- [x] use `details` for each submitting procedure
- [x] shorten WG titles, use description for details
- [ ] some example of WG3 activities missing
@leclairm
Copy link
Contributor Author

leclairm commented Nov 13, 2023 •
edited
Loading

@ruthlorenz @jonasjucker @mjaehn @AnnikaLau This is a proposition reflecting personal taste, it's not (much) about content. Please tell if you disagree.

@leclairm leclairm linked an issue Nov 13, 2023 that may be closed by this pull request
Check Tasks #49
Closed
@leclairm leclairm changed the title ref(tasks): restructure tasks Restructure tasks Nov 14, 2023
@leclairm leclairm requested a review from mjaehn November 14, 2023 09:29
mjaehn
mjaehn requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spelling corrections.

Also: Do we want to add a TOC at the top of the page?

tasks/index.md Outdated Show resolved Hide resolved
tasks/index.md Outdated Show resolved Hide resolved
tasks/index.md Outdated Show resolved Hide resolved
tasks/index.md Outdated Show resolved Hide resolved
tasks/index.md Outdated Show resolved Hide resolved
tasks/index.md Outdated Show resolved Hide resolved
leclairm and others added 5 commits November 14, 2023 11:01
@leclairm @mjaehn
fix(tasks): typos and litteral numbers
1abfb33 
Co-authored-by: Michael Jähn <[email protected]>
@leclairm @mjaehn
fix(tasks): typo
4036180 
Co-authored-by: Michael Jähn <[email protected]>
@leclairm @mjaehn
fix(tasks): typo
ab7d694 
Co-authored-by: Michael Jähn <[email protected]>
@leclairm @mjaehn
fix(tasks): typo
e2e8e83 
Co-authored-by: Michael Jähn <[email protected]>
@leclairm @mjaehn
fix(tasks): change semi-annual for biannual
eb48146 
Co-authored-by: Michael Jähn <[email protected]>
@leclairm
Copy link
Contributor Author

Also: Do we want to add a TOC at the top of the page?

I was not sure it's big enough of a page for it but I can add a collapsible one.

@leclairm
add,test(tasks): try out a collapsible table of content
9f68c2a 
Found no way to control the depth of TOC so manually added {: .no_toc}
to low-level headings
@leclairm
Copy link
Contributor Author

Also: Do we want to add a TOC at the top of the page?

I was not sure it's big enough of a page for it but I can add a collapsible one.

Just did that, have a look. Not sure it adds a lot and it's rather large compared to the rest of the page. I mean nothing is far away by just scrolling.

@leclairm
ref(tasks): looks better with attention-title than note
fcfcaea 
No need for a "note" title in the box
@mjaehn
Copy link
Contributor

mjaehn commented Nov 14, 2023

Also: Do we want to add a TOC at the top of the page?

I was not sure it's big enough of a page for it but I can add a collapsible one.

Just did that, have a look. Not sure it adds a lot and it's rather large compared to the rest of the page. I mean nothing is far away by just scrolling.

Actually I like it a lot, it is a good overview and folks can jump directly to a certain topic / WG. Plus it is collapsible.

Two more suggestions from @jonasjucker and me:

  • The "below" / "bellow" links are not necessary as they don't add much value by just pointing to a section that is directly underneath.
  • What is the motivation for displaying "e.g." in italics?

@leclairm
Copy link
Contributor Author

Also: Do we want to add a TOC at the top of the page?

I was not sure it's big enough of a page for it but I can add a collapsible one.

Just did that, have a look. Not sure it adds a lot and it's rather large compared to the rest of the page. I mean nothing is far away by just scrolling.

Actually I like it a lot, it is a good overview and folks can jump directly to a certain topic / WG. Plus it is collapsible.

Two more suggestions from @jonasjucker and me:

* The "below" / "bellow" links are not necessary as they don't add much value by just pointing to a section that is directly underneath.

The motivation is that "below" doesn't say much. Maybe I try to find other words if I remove the link.
And "bellow" is a totally unrelated word ;-)

* What is the motivation for displaying "e.g." in _italics_?

That was for correct typography but it seems it's not necessary anymore. However it needs a comma after.

@leclairm
Copy link
Contributor Author

The motivation is that "below" doesn't say much. Maybe I try to find other words if I remove the link.

Well actually that's fine. I removed the links and kept "below". The page is not big enough for these sort of links to be useful.

@leclairm
del(tasks): remove useless links
9468b61 
also write "three" in word and slightly rephrase the part about issues
to avoid repetitions.
@leclairm
Copy link
Contributor Author

The page is not big enough for these sort of links to be useful.

Which I would argue also holds for the table of content ;-). But that's fine, it's fancy collapsible, we can keep it

@leclairm
Copy link
Contributor Author

@mjaehn seems like you'r estill requeting changes but I can't figure out where.

@leclairm leclairm merged commit d8c7a33 into main Nov 14, 2023
2 checks passed
@leclairm leclairm deleted the tasks branch November 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjaehn mjaehn mjaehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check Tasks
2 participants
@leclairm @mjaehn