-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip offset provider when connectivity is missing #373
Conversation
cscs-ci run default |
It seems that you need to write one line per comment, in order to trigger each job. Please also trigger |
cscs-ci run benchmark |
launch jenkins spack |
The benchmark fail has nothing do do with your change. We had changed the TESTDATA mount at the same time. Sorry. You will have to rerun with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can you open an issue in icon4py that we properly calculate the connectivity and add it to the grid? We will need to work on the grid anyway in some upcoming projects.
Forgot to submit the issue yesterday... Here we go: #374 |
cscs-ci run benchmark |
cscs-ci run benchmark |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run default |
launch jenkins spack |
The
IconGrid
is missing some connectivities (that are present in thesimple_grid
). For example 7696d1a introduced the offset provider forC2CECEC
, but we do not construct the respective connectivity. This PR just skips all offset providers for which the respective connectivity does not exist and prints a warning. This fixes executing with the icon grid again.EDIT: Blocked by #372