Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip offset provider when connectivity is missing #373

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

tehrengruber
Copy link
Contributor

@tehrengruber tehrengruber commented Feb 1, 2024

The IconGrid is missing some connectivities (that are present in the simple_grid). For example 7696d1a introduced the offset provider for C2CECEC, but we do not construct the respective connectivity. This PR just skips all offset providers for which the respective connectivity does not exist and prints a warning. This fixes executing with the icon grid again.

EDIT: Blocked by #372

@tehrengruber
Copy link
Contributor Author

cscs-ci run default
launch jenkins spack

@edopao
Copy link
Contributor

edopao commented Feb 1, 2024

It seems that you need to write one line per comment, in order to trigger each job. Please also trigger cscs-ci run benchmark in order to see how it affects benchmark execution.

@tehrengruber
Copy link
Contributor Author

cscs-ci run benchmark

@tehrengruber
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor

halungge commented Feb 1, 2024

The benchmark fail has nothing do do with your change. We had changed the TESTDATA mount at the same time. Sorry. You will have to rerun with TEST_DATA_PATH: "/project/d121/icon4py/ci/testdata"

Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you open an issue in icon4py that we properly calculate the connectivity and add it to the grid? We will need to work on the grid anyway in some upcoming projects.

@tehrengruber
Copy link
Contributor Author

Forgot to submit the issue yesterday... Here we go: #374

@tehrengruber
Copy link
Contributor Author

cscs-ci run benchmark

@tehrengruber
Copy link
Contributor Author

cscs-ci run benchmark

Copy link

github-actions bot commented Feb 1, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@tehrengruber
Copy link
Contributor Author

cscs-ci run default

@tehrengruber
Copy link
Contributor Author

launch jenkins spack

@tehrengruber tehrengruber merged commit db6334d into main Feb 1, 2024
5 of 6 checks passed
@samkellerhals samkellerhals deleted the skip_offset_provider branch December 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants