Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format assignee component #184

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Format assignee component #184

merged 2 commits into from
Jul 23, 2023

Conversation

joyngjr
Copy link
Contributor

@joyngjr joyngjr commented Jul 22, 2023

Summary:

Fixes #181

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Show entire username instead of scrollbar in assignee header

Screenshots:

Screenshot 2023-07-22 at 11 19 50 PM

Proposed Commit Message:

Fix elements spilling out of assignee header component when username is too long.

Let's wrap long usernames instead of using a scrollbar.

Checklist:
  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@joyngjr
Contain assignee header elements within tile for long usernames
e8927dd
@joyngjr
Merge branch 'main' into format-assignee-component
1a69b8b 
* main:
  Add reset labels feature (CATcher-org#150)
  Allow keyboard enter when changing repository (CATcher-org#177)
  Fix ng test type error (CATcher-org#175)
  Reduce code duplication in repository url suggestions (CATcher-org#170)
  Fix hover, click interaction with issue cards (CATcher-org#173)
  [CATcher-org#72] Remove unused code from catcher models (CATcher-org#146)
  [CATcher-org#72] Remove package ngx-markdown (CATcher-org#145)
  Extract method from header.component into phase.service.ts (CATcher-org#162)
  [CATcher-org#72] Remove code related to creating and updating repos (CATcher-org#143)
  Autofill repository URL with Browser Cache (CATcher-org#159)
  Update PR template (CATcher-org#157)
  Update Readme (CATcher-org#158)
  Enclose PR/issues in scrollable container (CATcher-org#148)
  Show loading spinner on switch repository (CATcher-org#151)
  Add wrap for username in issues-viewer's card-view (CATcher-org#147)
  Update website title after changing repository (CATcher-org#141)
  Disable milestone filter if there are no milestones (CATcher-org#149)
  Fix pressing back to cause issues to being cleared (CATcher-org#142)
gycgabriel
gycgabriel approved these changes Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gycgabriel gycgabriel merged commit d96803f into CATcher-org:main Jul 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gycgabriel gycgabriel gycgabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format assignee elements
2 participants
@joyngjr @gycgabriel