Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated async #201

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Fix deprecated async #201

merged 7 commits into from
Sep 11, 2023

Conversation

wweqg
Copy link
Contributor

@wweqg wweqg commented Sep 7, 2023

Summary:

Fixes #200

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Update the use of async() to waitForAsync()

Proposed Commit Message:

Update the deprecated async function call to waitForAsync()

Checklist:
  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Echomo-Xinyu
Echomo-Xinyu previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Echomo-Xinyu Echomo-Xinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Echomo-Xinyu
Echomo-Xinyu approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Echomo-Xinyu Echomo-Xinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Echomo-Xinyu Echomo-Xinyu merged commit 0829bab into CATcher-org:main Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Echomo-Xinyu Echomo-Xinyu Echomo-Xinyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated 'async' in confirm-login.component.spec.ts file
2 participants
@wweqg @Echomo-Xinyu