Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-open Prompt for Invalid Repos #209

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

joyngjr
Copy link
Contributor

@joyngjr joyngjr commented Sep 25, 2023

Summary:

Fixes #204

Type of change:

  • ✨ Enhancement

Changes Made:

  • Reopen repo-change-form when users try to change to an invalid repository

Screenshots:

Screen.Recording.2023-09-25.at.6.40.12.PM.mov

Proposed Commit Message:

Enhance error handling for switching to invalid repos.

Let's re-open the page to change repos when an invalid one is entered.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Copy link
Collaborator

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunweii chunweii merged commit 8de2f78 into CATcher-org:main Oct 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for repo again if the provided repo cannot be found
3 participants